Bug 14465 - Broken umlauts/diacritics in feedback of last checkout
Summary: Broken umlauts/diacritics in feedback of last checkout
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.18
Hardware: All All
: P5 - low major (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 13315
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-26 11:23 UTC by Katrin Fischer
Modified: 2016-06-21 21:36 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot showing the problem (18.20 KB, image/png)
2015-06-26 11:23 UTC, Katrin Fischer
Details
Bug 14465 - Broken umlauts/diacritics in feedback of last checkout (1.71 KB, patch)
2015-06-26 11:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 14465 - Broken umlauts/diacritics in feedback of last checkout (1.77 KB, patch)
2015-06-26 12:57 UTC, Amit Gupta
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout (1.81 KB, patch)
2015-06-26 12:58 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA][3.18.x] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout (1.91 KB, patch)
2015-06-26 15:28 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-06-26 11:23:37 UTC
Created attachment 40650 [details]
Screenshot showing the problem

This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot).

This is a really prominent place to display broken encoding.
Comment 1 Kyle M Hall 2015-06-26 11:59:33 UTC Comment hidden (obsolete)
Comment 2 Amit Gupta 2015-06-26 12:34:51 UTC
Commit Body is:
--------------------------
Bug 14465 - Broken umlauts/diacritics in feedback of last checkout

This was tested in 3.18 after upgrading to the security release. The
feedback on the last checkout information introcuded by bug 13315 has
encoding problems in the displayed title (see screenshot).

This is a really prominent place to display broken encoding.

Test Plan:
1) Apply this patch
2) Check out an item with broken encoding
3) Note the title now displays properly
--------------------------
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all a
Applying: Bug 14465 - Broken umlauts/diacritics in feedback of last checkout
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Failed to merge in the changes.
Patch failed at 0001 Bug 14465 - Broken umlauts/diacritics in feedback of last checkout
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Comment 3 Bernardo Gonzalez Kriegel 2015-06-26 12:51:33 UTC
(In reply to Amit from comment #2)
> Patch failed at 0001 Bug 14465 - Broken umlauts/diacritics in feedback of

It's for 3.18.x branch
Comment 4 Amit Gupta 2015-06-26 12:53:54 UTC
oh! sorry will test on 3.18.x
Comment 5 Amit Gupta 2015-06-26 12:57:23 UTC Comment hidden (obsolete)
Comment 6 Bernardo Gonzalez Kriegel 2015-06-26 12:58:15 UTC Comment hidden (obsolete)
Comment 7 Bernardo Gonzalez Kriegel 2015-06-26 12:58:53 UTC
(In reply to Amit from comment #4)
> oh! sorry will test on 3.18.x

I win :)
Comment 8 Bernardo Gonzalez Kriegel 2015-06-26 13:02:30 UTC
(In reply to Bernardo Gonzalez Kriegel from comment #7)
> (In reply to Amit from comment #4)
> > oh! sorry will test on 3.18.x
> 
> I win :)

No, you did, I'll obsolete my patch
Regards
Comment 9 Katrin Fischer 2015-06-26 15:28:11 UTC
Created attachment 40679 [details] [review]
[PASSED QA][3.18.x] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout

This was tested in 3.18 after upgrading to the security release. The
feedback on the last checkout information introcuded by bug 13315 has
encoding problems in the displayed title (see screenshot).

This is a really prominent place to display broken encoding.

Test Plan:
1) Apply this patch
2) Check out an item with broken encoding
3) Note the title now displays properly

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
We already put it in production... so this better works :)
Comment 10 Katrin Fischer 2015-07-23 22:35:38 UTC
This one is only for 3.18.x!
Comment 11 Liz Rea 2015-07-23 23:14:02 UTC
Pushed to 3.18.x will be in 3.18.10.