Bugzilla – Attachment 41101 Details for
Bug 14571
using_https check for ssl connections doesn't work in some situations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14571: HTTPS Amazon images [follow up]
Bug-14571-HTTPS-Amazon-images-follow-up.patch (text/plain), 2.69 KB, created by
Liz Rea
on 2015-07-20 23:22:54 UTC
(
hide
)
Description:
Bug 14571: HTTPS Amazon images [follow up]
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2015-07-20 23:22:54 UTC
Size:
2.69 KB
patch
obsolete
>From 41dcae5be8ebde15c163e8a45a2aec8f6d25c929 Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Tue, 21 Jul 2015 10:46:14 +1200 >Subject: [PATCH] Bug 14571: HTTPS Amazon images [follow up] > >I found a couple more places where we should be using images-na, so I updated them > >* in the shelf browser >* in XISBN related works (honestly not sure how to test this one, but changing from the http:// url won't hurt anything.) > >To test: > >* Turn on the shelf browser, and browse for an item that has an amazon image, >* inspect it, it should be using https://images-na... url. >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >index 255fac1..6651406 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >@@ -26,7 +26,7 @@ > [% END %] > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( item.browser_normalized_isbn ) %] >- <img src="http://images.amazon.com/images/P/[% item.browser_normalized_isbn %].01._AA75_PU_PU-5_.jpg" alt="" /> >+ <img src="https://images-na.ssl-images-amazon.com/images/P/[% item.browser_normalized_isbn %].01._AA75_PU_PU-5_.jpg" alt="" /> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index a61d165..019b367 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -959,7 +959,7 @@ > <tr> > <td> > [% IF ( OPACAmazonCoverImages ) %] >- <img src="http://images.amazon.com/images/P/[% XISBN.normalized_isbn %].01._AA75_PU_PU-5_.jpg" alt="" /> >+ <img src="https://images-na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn %].01._AA75_PU_PU-5_.jpg" alt="" /> > [% END %] > > [% IF ( SyndeticsEnabled && SyndeticsCoverImages ) %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14571
:
41100
|
41101
|
41102
|
46229
|
46230
|
46231
|
46418
|
46419
|
46420
|
46421
|
51640