This is especially problematic for Amazon images, since if the check fails the normal images are used, causing mixed content warnings. I think we should remove the checks from Amazon images in the OPAC and just use the https Amazon url's for images.
Created attachment 41100 [details] [review] Bug 14571: using_https check for ssl connections doesn't work in some situations To test: * turn on Amazon images for result and detail in the OPAC * do a search that will result in an Amazon image being displayed on the result page * inspect the cover image that is returned on the result page, it should be using a https://images-na... Amazon URL. * click through to the detail for that item * inspect the cover image that is returned on the detail page, it should be using a https://images-na... Amazon URL.
Created attachment 41101 [details] [review] Bug 14571: HTTPS Amazon images [follow up] I found a couple more places where we should be using images-na, so I updated them * in the shelf browser * in XISBN related works (honestly not sure how to test this one, but changing from the http:// url won't hurt anything.) To test: * Turn on the shelf browser, and browse for an item that has an amazon image, * inspect it, it should be using https://images-na... url.
Created attachment 41102 [details] [review] Bug 14571 - More switching of Amazon image source URL to https modified: modules/opac-opensearch.tt modified: modules/opac-results-grouped.tt modified: modules/opac-shelves.tt modified: modules/opac-showreviews-rss.tt modified: modules/opac-showreviews.tt Basically, just inspect these places and make sure the Amazon images are using https://images-na instead of http://images
Can we get a sign off on this please, I can't sign it off.
Created attachment 46229 [details] [review] [SIGNED-OFF] Bug 14571: using_https check for ssl connections doesn't work in some situations To test: * turn on Amazon images for result and detail in the OPAC * do a search that will result in an Amazon image being displayed on the result page * inspect the cover image that is returned on the result page, it should be using a https://images-na... Amazon URL. * click through to the detail for that item * inspect the cover image that is returned on the detail page, it should be using a https://images-na... Amazon URL. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 46230 [details] [review] [SIGNED-OFF] Bug 14571: HTTPS Amazon images [follow up] I found a couple more places where we should be using images-na, so I updated them * in the shelf browser * in XISBN related works (honestly not sure how to test this one, but changing from the http:// url won't hurt anything.) To test: * Turn on the shelf browser, and browse for an item that has an amazon image, * inspect it, it should be using https://images-na... url. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 46231 [details] [review] [SIGNED-OFF] Bug 14571 - More switching of Amazon image source URL to https modified: modules/opac-opensearch.tt modified: modules/opac-results-grouped.tt modified: modules/opac-shelves.tt modified: modules/opac-showreviews-rss.tt modified: modules/opac-showreviews.tt Basically, just inspect these places and make sure the Amazon images are using https://images-na instead of http://images Signed-off-by: Owen Leonard <oleonard@myacpl.org>
There are 2 more left, is it expected? koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" />
I didn't go after the intranet here, but I didn't specify so I'll add a followup. :) Liz
Can we get these ones through first though? I'll make a different bug for the intranet detail. Cheers, Liz
Created attachment 46418 [details] [review] Bug 14571: using_https check for ssl connections doesn't work in some situations To test: * turn on Amazon images for result and detail in the OPAC * do a search that will result in an Amazon image being displayed on the result page * inspect the cover image that is returned on the result page, it should be using a https://images-na... Amazon URL. * click through to the detail for that item * inspect the cover image that is returned on the detail page, it should be using a https://images-na... Amazon URL. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 46419 [details] [review] Bug 14571: HTTPS Amazon images [follow up] I found a couple more places where we should be using images-na, so I updated them * in the shelf browser * in XISBN related works (honestly not sure how to test this one, but changing from the http:// url won't hurt anything.) To test: * Turn on the shelf browser, and browse for an item that has an amazon image, * inspect it, it should be using https://images-na... url. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 46420 [details] [review] Bug 14571 - More switching of Amazon image source URL to https modified: modules/opac-opensearch.tt modified: modules/opac-results-grouped.tt modified: modules/opac-shelves.tt modified: modules/opac-showreviews-rss.tt modified: modules/opac-showreviews.tt Basically, just inspect these places and make sure the Amazon images are using https://images-na instead of http://images Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 46421 [details] [review] Bug 14571 - Intranet detail needs ssl sources for Amazon images To test: Enable Amazon images for the staff client - syspref: AmazonCoverImages -> Show Go to a record detail in the intranet that has an Amazon image, inspect it, and make sure that it 1. Shows 2. has https://images-na. and not http://images. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Liz Rea from comment #10) > Can we get these ones through first though? I'll make a different bug for > the intranet detail. > > Cheers, > Liz I have embedded it in this patch set.
*** Bug 15518 has been marked as a duplicate of this bug. ***
Sweet as, thanks!
Pushed to Master - Should be in the May 2016 release. Thanks!
This seems to be limited to Amazon cover images. If so, why? How about the other providers like Open Library where I run into a similar problem (HTTP API call blocked for a full HTTPS Koha site). Thanks
Created attachment 51640 [details] [review] Use SSL when querying Open Library API FWIW, here's a patch to use SSL for Open Library as well...
(In reply to Oliver Bock from comment #20) > Created attachment 51640 [details] [review] [review] > Use SSL when querying Open Library API > > FWIW, here's a patch to use SSL for Open Library as well... Would you please open a new bug report (and link it to this one) to attach your patch? This one is marked as "pushed to master" and new patches should go on their own bug report.
(In reply to Jonathan Druart from comment #21) > Would you please open a new bug report (and link it to this one) to attach > your patch? > This one is marked as "pushed to master" and new patches should go on their > own bug report. Done: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615