Attachment 4148 Details for Bug 6351 – Patch, tested and signed off

[patch] Patch, tested and signed off

0001-SIGNED-OFF-Bug-6351-Unable-to-delete-branch-specific.patch (text/plain), 1.14 KB, created by Katrin Fischer on 2011-05-17 17:10:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2011-05-17 17:10:15 UTC

Size: 1.14 KB

patch

obsolete

>From 7541e613847fd97e0a5a76359be776a4f2efcdac Mon Sep 17 00:00:00 2001
>From: D Ruth Bavousett <ruth@bywatersolutions.com>
>Date: Tue, 17 May 2011 11:45:48 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 6351: Unable to delete branch-specific circulation rule
>Content-Type: text/plain; charset="utf-8"
>
>The URL on the page did not have a branchcode, so the delete failed silently, and
>returned the user to the "All" rules page.  Turns out, the array for the rules was
>not being populated with the branchcode!
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>---
> admin/smart-rules.pl |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl
>index 3c77f93..5ba92d8 100755
>--- a/admin/smart-rules.pl
>+++ b/admin/smart-rules.pl
>@@ -376,6 +376,7 @@ my $sth2 = $dbh->prepare("
> $sth2->execute($branch);
> 
> while (my $row = $sth2->fetchrow_hashref) {
>+    $row->{'current_branch'} ||= $row->{'branchcode'};
>     $row->{'humanitemtype'} ||= $row->{'itemtype'};
>     $row->{'default_humanitemtype'} = 1 if $row->{'humanitemtype'} eq '*';
>     $row->{'humancategorycode'} ||= $row->{'categorycode'};
>-- 
>1.7.4.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 6351: 4142 | 4148 | 5228 | 5229