Adding and deleting rules for "All" libraries works fine; if you add a rule for a specific library, however, then an attempt to delete it will take you back to the "All" page, and not actually delete the rule. No errors are being thrown to the logs, as far as I can tell, so it doesn't seem to be malformed SQL or anything *easy* like that.
Katrin is a GENIUS! The URL for the "Delete" link does not contain a branchcode; that may well be the root to the problem...a templating issue.
Manually repairing the URL with the branchcode causes the command to work properly.
Created attachment 4142 [details] [review]
Created attachment 4148 [details] [review]
Patch, tested and signed off
Easy to read to confirm. Marking as Passed QA.
Pushed, please test
Deleting rules for 'all libraries' works without problems on current master. Marking fixed.
While this fix works just fine, there are additional areas on the Circulation Fines and Rules page that have a similar error. Holds Policies by item type and Checkout Limits by patron category cannot be deleted due to a T:T scope issue. Patch forthcoming.
Created attachment 5228 [details] [review]
Proposed Followup Patch
Fixes T:T scope error on Checkout Limit by Patron Category and Holds Policy by Item Type delete links
Created attachment 5229 [details] [review]
[Signed Off] Bug 6351: Cannot delete library-specific holds polices and checkout limits
Template::Toolkit scope error on delete links on Checkout Limit by Patron Category
and Holds Policy by Item Type areas.
Tested adding and removing Checkout Limits by Patron Category - both work
Tested adding and removing Holds Policies by ItemTypes - both work
Signed-off-by: Liz Rea <firstname.lastname@example.org>
Since it is a template only change, even though I'm the author, I'm going to mark this as Passed QA. Please object, anyone, if you take issue.
Pushed please test
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.