Bugzilla – Attachment 41615 Details for
Bug 14529
Cannot delete a list even if the permission is set
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 14529: Allow user to delete lists
SIGNED-OFF-Bug-14529-Allow-user-to-delete-lists.patch (text/plain), 3.04 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-08-18 15:30:13 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 14529: Allow user to delete lists
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-08-18 15:30:13 UTC
Size:
3.04 KB
patch
obsolete
>From b46c8b8698b417ed6aa596d1cd567817b9bf753a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 13 Jul 2015 17:53:06 +0100 >Subject: [PATCH] [SIGNED OFF] Bug 14529: Allow user to delete lists > >Bug 13417 allows a librarian to delete any lists if he has the >permission (delete_public_lists). > >There is a mismatch in the perm check. >A user can delete a list with the ability to edit (manage) it. > >Test plan: >1/ Create a list A with user A >2/ Create a list B with user B >3/ A should be able to manage and delete the list A. >He cans delete B only if he is superlibrarian or has the >delete_public_lists permission. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >--- > .../prog/en/modules/virtualshelves/tables/shelves_results.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt >index 65a7459..01ceb8a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt >@@ -28,8 +28,8 @@ > } > > [% BLOCK action_form -%] >- [%- IF can_manage_shelf -%] >-<form action='shelves.pl' method='get'><input type='hidden' name='shelfnumber' value='[% shelfnumber %]' /><input type='hidden' name='op' value='modif' /><input type='submit' class='editshelf' value='Edit' /></form>[% IF can_manage_shelf OR can_delete_shelf %]<form action='shelves.pl' method='post'><input type='hidden' name='shelfoff' value='[% shelfoff %]' /><input type='hidden' name='shelves' value='1' /><input type='hidden' name='DEL-[% shelfnumber %]' value='1' /><input type='hidden' name='CONFIRM-[% shelfnumber %]' value='1' />[% IF type == 1 %]<input type='hidden' name='display' value='privateshelves' />[% ELSE %]<input type='hidden' name='display' value='publicshelves' />[% END %]<input type='submit' class='deleteshelf' onclick='return confirmDelete(MSG_CONFIRM_DELETE_LIST)' value='Delete' /></form>[% END %] >+ [%- IF can_manage_shelf OR can_delete_shelf-%] >+[% IF can_manage_shelf %]<form action='shelves.pl' method='get'><input type='hidden' name='shelfnumber' value='[% shelfnumber %]' /><input type='hidden' name='op' value='modif' /><input type='submit' class='editshelf' value='Edit' /></form>[% END %][% IF can_manage_shelf OR can_delete_shelf %]<form action='shelves.pl' method='post'><input type='hidden' name='shelfoff' value='[% shelfoff %]' /><input type='hidden' name='shelves' value='1' /><input type='hidden' name='DEL-[% shelfnumber %]' value='1' /><input type='hidden' name='CONFIRM-[% shelfnumber %]' value='1' />[% IF type == 1 %]<input type='hidden' name='display' value='privateshelves' />[% ELSE %]<input type='hidden' name='display' value='publicshelves' />[% END %]<input type='submit' class='deleteshelf' onclick='return confirmDelete(MSG_CONFIRM_DELETE_LIST)' value='Delete' /></form>[% END %] > [%- ELSE -%] > None > [%- END -%] >-- >2.5.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14529
:
40976
|
41578
|
41613
|
41614
|
41615
|
41616
|
41617
|
41618