Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists).
Created attachment 40976 [details] [review] Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission.
In testing I can only delete another users public lists with superlibrarian permission. The button doesn't appear when 'delete_public_lists' is checked
I have just retested and it works for me. Could you give me more details please? The button should appears on the list view: /cgi-bin/koha/virtualshelves/shelves.pl, tab "Public lists".
Created attachment 41578 [details] [review] Bug 14529: The new list permission is 'lists', not 'shelves'
Created attachment 41613 [details] [review] [SIGNED-OFF] Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 41614 [details] [review] [SIGNED-OFF] Bug 14529: The new list permission is 'lists', not 'shelves' Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 41615 [details] [review] [SIGNED OFF] Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission. Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Created attachment 41616 [details] [review] [SIGNED OFF] Bug 14529: The new list permission is 'lists', not 'shelves' Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Created attachment 41617 [details] [review] [PASSED QA] Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission. Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 41618 [details] [review] [PASSED QA] Bug 14529: The new list permission is 'lists', not 'shelves' Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patches pushed to master. Thanks Jonathan!
Template changes holding for 3.20.4