Bugzilla – Attachment 42497 Details for
Bug 7634
Permanent Location (shelving location) is NULL when Import MARC records tool is used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 7634: Prevent permanent_location to be set to NULL if not defined
PASSED-QA-Bug-7634-Prevent-permanentlocation-to-be.patch (text/plain), 1.51 KB, created by
Katrin Fischer
on 2015-09-13 15:34:14 UTC
(
hide
)
Description:
[PASSED QA] Bug 7634: Prevent permanent_location to be set to NULL if not defined
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-09-13 15:34:14 UTC
Size:
1.51 KB
patch
obsolete
>From e42125e6c5df2f938aec691f248cb6ee3b1a93ce Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 2 Sep 2015 14:28:52 +0100 >Subject: [PATCH] [PASSED QA] Bug 7634: Prevent permanent_location to be set to > NULL if not defined > >The permanent_location is correctly filled when an item is added from >the cataloguing module (routine set_item_default_location from >cataloguing/additem.pl). >But when records are imported, this filled is not managed. It's only on >editing (_do_column_fixes_for_mod called from ModItem). > >This patch set the permanent_location item fields to the location value for all >items created, even the imported ones. > >Test plan: >0/ Do not apply this patch >1/ Import a record with items using the "Stage MARC for import" tool >2/ Check the values for the permanent_location in the items table. >They are set to NULL >3/ Apply this patch >4/ Repeat 2 and confirm that now the permanent_location values are set >to the location values. > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Items.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 0e639dc..1c6d7ef 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -2144,6 +2144,7 @@ sub _koha_new_item { > my ( $item, $barcode ) = @_; > my $dbh=C4::Context->dbh; > my $error; >+ $item->{permanent_location} //= $item->{location}; > my $query = > "INSERT INTO items SET > biblionumber = ?, >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7634
:
42222
|
42223
|
42224
|
42260
|
42261
|
42262
|
42495
|
42496
| 42497