Bugzilla – Attachment 43323 Details for
Bug 14841
Columns settings on checkouts table have 2 bugs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14841: Columns settings are not taken into account for checkout table / moremember
PASSED-QA-Bug-14841-Columns-settings-are-not-taken.patch (text/plain), 1.98 KB, created by
Katrin Fischer
on 2015-10-12 05:23:11 UTC
(
hide
)
Description:
[PASSED QA] Bug 14841: Columns settings are not taken into account for checkout table / moremember
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-10-12 05:23:11 UTC
Size:
1.98 KB
patch
obsolete
>From 525ac3677b8e460952036cbc5a625ab2c7b6a72c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 17 Sep 2015 08:34:28 +0100 >Subject: [PATCH] [PASSED QA] Bug 14841: Columns settings are not taken into > account for checkout table / moremember >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >There is a typo member vs members in the template when retrieving the >existing settings. >So that all columns are displayed, even the ones which are hidden >(sort_order, due_date_unformatted, etc.) > >Test plan: >0/ Does not apply this patch >1/ Go on the columns config page and check some fields not to display by >default for Patrons > moremember > issues-table >2/ Go on the patron detail page (with checkouts), click on the "show/hide >columns" button (top right of the table). >Confirm that the config is not taken into account and that it's ugly >(hidden columns are displayed) >3/ Apply this patch >4/ Everything should be fine now :) > >Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 5a8c5a9..96f51aa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -43,7 +43,7 @@ var relatives_borrowernumbers = new Array(); > var MSG_ADD_MESSAGE = _("Add a new message"); > var MSG_EXPORT_SELECT_CHECKOUTS = _("You must select checkout(s) to export"); > >-columns_settings = [% ColumnsSettings.GetColumns( 'member', 'moremember', 'issues-table', 'json' ) %] >+columns_settings = [% ColumnsSettings.GetColumns( 'members', 'moremember', 'issues-table', 'json' ) %] > > $(document).ready(function() { > $('#finesholdsissues').tabs({ >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14841
:
42635
|
42636
|
43102
|
43105
|
43321
|
43322
| 43323 |
43324