1/ The settings defined on the administration page are not taken into account 2/ The "Fines" column does not appear in the field list.
Created attachment 42635 [details] [review] Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :)
Created attachment 42636 [details] [review] Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table.
Bugs 9481 and 13492 are in 3.20.x, this should be backported.
Created attachment 43102 [details] [review] Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 43105 [details] [review] Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 43321 [details] [review] Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 43322 [details] [review] [PASSED QA] Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 43323 [details] [review] [PASSED QA] Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 43324 [details] [review] [PASSED QA] Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Jonathan!
*** Bug 14657 has been marked as a duplicate of this bug. ***
(In reply to Jonathan Druart from comment #3) > Bugs 9481 and 13492 are in 3.20.x, this should be backported. That bug still exists on 3.20.x (see bug 14657).
Pushed to 3.20.x. Will be in 3.20.11. Thanks Jonathan.