Attachment 43814 Details for Bug 15021 – [PASSED QA] Bug 15021: Fix scoping variable in tools/batchMod.pl

[patch] [PASSED QA] Bug 15021: Fix scoping variable in tools/batchMod.pl

PASSED-QA-Bug-15021-Fix-scoping-variable-in-toolsb.patch (text/plain), 1.12 KB, created by Kyle M Hall (khall) on 2015-10-23 10:43:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-10-23 10:43:02 UTC

Size: 1.12 KB

patch

obsolete

>From 84633b8336100317a681d1f999d19aa3645c5cfb Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 16 Oct 2015 08:45:30 +0000
>Subject: [PATCH] [PASSED QA] Bug 15021: Fix scoping variable in tools/batchMod.pl
>
>$tagslib is used in subroutines and should be declare as global.
>
>Test plan:
>On the Batch item modification page, all item fields should be listed, not only the title.
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>Works as expected
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> tools/batchMod.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/tools/batchMod.pl b/tools/batchMod.pl
>index 055e407..5804936 100755
>--- a/tools/batchMod.pl
>+++ b/tools/batchMod.pl
>@@ -82,7 +82,7 @@ my $itemrecord;
> my $nextop="";
> my @errors; # store errors found while checking data BEFORE saving item.
> my $items_display_hashref;
>-my $tagslib = &GetMarcStructure(1);
>+our $tagslib = &GetMarcStructure(1);
> 
> my $deleted_items = 0;     # Number of deleted items
> my $deleted_records = 0;   # Number of deleted records ( with no items attached )
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 15021: 43450 | 43468 | 43488 | 43814