Attachment 44106 Details for Bug 15059 – Bug 15059 - Line break in html attribute in branchoverdues.tt

[patch] Bug 15059 - Line break in html attribute in branchoverdues.tt

Bug-15059---Line-break-in-html-attribute-in-branch.patch (text/plain), 3.40 KB, created by Fridolin Somers on 2015-10-28 08:52:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2015-10-28 08:52:43 UTC

Size: 3.40 KB

patch

obsolete

>From 829badb79819c47dbcbbbeb14fd44df4e6079df3 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 26 Oct 2015 08:44:17 +0100
>Subject: [PATCH] Bug 15059 - Line break in html attribute in branchoverdues.tt
>
>In circ/branchoverdues.tt, there is a line break inside href attribute.
>This generates an attribute with a lot of spaces %20.
>
>Test plan :
>- at intranet go to ciculation module
>- click on "Overdues with fines"
>- look at links "Phone", "Notice" and "Considered lost"
>=> Without patch the URL contains a lot of spaces
>=> With patch the URL is correct
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt
>index dd2d7e6..ff3424d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt
>@@ -77,11 +77,9 @@
>                             Mail
>                         [% END %]
>                             &nbsp;|&nbsp;
>-                            <a href="branchoverdues.pl?action=add&amp;borrowernumber=[% overduesloo.borrowernumber %]&amp;itemnumber=[% overduesloo.itemnumber %]&amp;method=phone&amp;location=[% overduesloo.location %]&amp;overduelevel=[% overduesloo.overdueLevel %]&amp;notifyId=[% overduesloo.notify_id %]
>-                            ">Phone</a>
>+                            <a href="branchoverdues.pl?action=add&amp;borrowernumber=[% overduesloo.borrowernumber %]&amp;itemnumber=[% overduesloo.itemnumber %]&amp;method=phone&amp;location=[% overduesloo.location %]&amp;overduelevel=[% overduesloo.overdueLevel %]&amp;notifyId=[% overduesloo.notify_id %]">Phone</a>
>                             &nbsp;|&nbsp;
>-                            <a href="branchoverdues.pl?action=add&amp;borrowernumber=[% overduesloo.borrowernumber %]&amp;itemnumber=[% overduesloo.itemnumber %]&amp;method=letter&amp;location=[% overduesloo.location %]&amp;overduelevel=[% overduesloo.overdueLevel %]
>-                            &amp;notifyId=[% overduesloo.notify_id %]">Notice</a>
>+                            <a href="branchoverdues.pl?action=add&amp;borrowernumber=[% overduesloo.borrowernumber %]&amp;itemnumber=[% overduesloo.itemnumber %]&amp;method=letter&amp;location=[% overduesloo.location %]&amp;overduelevel=[% overduesloo.overdueLevel %]&amp;notifyId=[% overduesloo.notify_id %]">Notice</a>
>                     [% END %]
> 
>                     [% IF ( overduesloo.overdue2 ) %]
>@@ -89,8 +87,7 @@
>                     [% END %]
> 
>                     [% IF ( overduesloo.overdue3 ) %]
>-                    <a href="branchoverdues.pl?action=add&amp;borrowernumber=[% overduesloo.borrowernumber %]&amp;itemnumber=[% overduesloo.itemnumber %]&amp;method=lost&amp;location=[% overduesloo.location %]&amp;overduelevel=[% overduesloo.overdueLevel %]
>-                    &amp;notifyId=[% overduesloo.notify_id %]">Considered lost</a>
>+                    <a href="branchoverdues.pl?action=add&amp;borrowernumber=[% overduesloo.borrowernumber %]&amp;itemnumber=[% overduesloo.itemnumber %]&amp;method=lost&amp;location=[% overduesloo.location %]&amp;overduelevel=[% overduesloo.overdueLevel %]&amp;notifyId=[% overduesloo.notify_id %]">Considered lost</a>
>                     [% END %]
> 
>                     </td>
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 15059: 43973 | 44042 | 44106 | 44112 | 44193