In some templates, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20.
Created attachment 43973 [details] [review] Bug 15059 - Line break in html attribute In some templates, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet (same at OPAC) - perform a search on one word with a sort order (anything but relevance) - click on "Next" at the bottom of the page - look at link "Show more" in facets => Without patch the URL contains a lot of spaces => With patch the URL is correct - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct
Created attachment 44042 [details] [review] Bug 15059 - Line break in html attribute In some templates, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet (same at OPAC) - perform a search on one word with a sort order (anything but relevance) - click on "Next" at the bottom of the page - look at link "Show more" in facets => Without patch the URL contains a lot of spaces => With patch the URL is correct - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Signed-off-by: Marc Véron <veron@veron.ch>
Please provide a fix on top of bug 14955
Created attachment 44106 [details] [review] Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct
(In reply to Jonathan Druart from comment #3) > Please provide a fix on top of bug 14955 Super, Bug 14955 fixes the facets includes. This patch will only fix branchoverdues.tt
(In reply to Fridolin SOMERS from comment #5) > (In reply to Jonathan Druart from comment #3) > > Please provide a fix on top of bug 14955 > > Super, Bug 14955 fixes the facets includes. > This patch will only fix branchoverdues.tt In this case, this bug can be tested without bug 14955.
Created attachment 44112 [details] [review] Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 44193 [details] [review] Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Does this one really depend on 14955?
Patch pushed to master. Thanks Frido!
Pushed to 3.18.13, and released.