Bugzilla – Attachment 44112 Details for
Bug 15059
Line break in html attribute
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15059 - Line break in html attribute in branchoverdues.tt
Bug-15059---Line-break-in-html-attribute-in-branch.patch (text/plain), 3.53 KB, created by
Marc Véron
on 2015-10-28 09:34:39 UTC
(
hide
)
Description:
Bug 15059 - Line break in html attribute in branchoverdues.tt
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-10-28 09:34:39 UTC
Size:
3.53 KB
patch
obsolete
>From c1c54f50ad571ded652762e9d1a04a02f97d43f7 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Mon, 26 Oct 2015 08:44:17 +0100 >Subject: [PATCH] Bug 15059 - Line break in html attribute in > branchoverdues.tt >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >In circ/branchoverdues.tt, there is a line break inside href attribute. >This generates an attribute with a lot of spaces %20. > >Test plan : >- at intranet go to ciculation module >- click on "Overdues with fines" >- look at links "Phone", "Notice" and "Considered lost" >=> Without patch the URL contains a lot of spaces >=> With patch the URL is correct > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > .../intranet-tmpl/prog/en/modules/circ/branchoverdues.tt | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt >index dd2d7e6..ff3424d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt >@@ -77,11 +77,9 @@ > Mail > [% END %] > | >- <a href="branchoverdues.pl?action=add&borrowernumber=[% overduesloo.borrowernumber %]&itemnumber=[% overduesloo.itemnumber %]&method=phone&location=[% overduesloo.location %]&overduelevel=[% overduesloo.overdueLevel %]&notifyId=[% overduesloo.notify_id %] >- ">Phone</a> >+ <a href="branchoverdues.pl?action=add&borrowernumber=[% overduesloo.borrowernumber %]&itemnumber=[% overduesloo.itemnumber %]&method=phone&location=[% overduesloo.location %]&overduelevel=[% overduesloo.overdueLevel %]&notifyId=[% overduesloo.notify_id %]">Phone</a> > | >- <a href="branchoverdues.pl?action=add&borrowernumber=[% overduesloo.borrowernumber %]&itemnumber=[% overduesloo.itemnumber %]&method=letter&location=[% overduesloo.location %]&overduelevel=[% overduesloo.overdueLevel %] >- &notifyId=[% overduesloo.notify_id %]">Notice</a> >+ <a href="branchoverdues.pl?action=add&borrowernumber=[% overduesloo.borrowernumber %]&itemnumber=[% overduesloo.itemnumber %]&method=letter&location=[% overduesloo.location %]&overduelevel=[% overduesloo.overdueLevel %]&notifyId=[% overduesloo.notify_id %]">Notice</a> > [% END %] > > [% IF ( overduesloo.overdue2 ) %] >@@ -89,8 +87,7 @@ > [% END %] > > [% IF ( overduesloo.overdue3 ) %] >- <a href="branchoverdues.pl?action=add&borrowernumber=[% overduesloo.borrowernumber %]&itemnumber=[% overduesloo.itemnumber %]&method=lost&location=[% overduesloo.location %]&overduelevel=[% overduesloo.overdueLevel %] >- &notifyId=[% overduesloo.notify_id %]">Considered lost</a> >+ <a href="branchoverdues.pl?action=add&borrowernumber=[% overduesloo.borrowernumber %]&itemnumber=[% overduesloo.itemnumber %]&method=lost&location=[% overduesloo.location %]&overduelevel=[% overduesloo.overdueLevel %]&notifyId=[% overduesloo.notify_id %]">Considered lost</a> > [% END %] > > </td> >-- >1.7.10.4
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=44112">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15059
:
43973
|
44042
|
44106
|
44112
|
44193