Bugzilla – Attachment 44856 Details for
Bug 14795
Batch record modification tool removes framework code
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 14795: Prevent modifying a record without using the original framework
SIGNED-OFF-Bug-14795-Prevent-modifying-a-record-wi.patch (text/plain), 1.69 KB, created by
Bernardo Gonzalez Kriegel
on 2015-11-13 18:16:21 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 14795: Prevent modifying a record without using the original framework
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2015-11-13 18:16:21 UTC
Size:
1.69 KB
patch
obsolete
>From 41d76b8dbc389db93003cb6bc628c741a2455536 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 13 Nov 2015 16:30:32 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 14795: Prevent modifying a record without > using the original framework > >The origin framework is not passed on modifying the records and so the >default one is used. >This can caused data lost. > >Test plan: >- Create a bibliographic record and specify a framework (not the default >one). >- Use the Batch records modification tools to modify it. >=> Without this patch, the default framework (framework code "") is used >and can deteriorate the record >=> With this patch, the record is saved using the original framework > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Tested framework is lost using tool without patch >Problem gone with patch >No qa errors >--- > tools/batch_record_modification.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/tools/batch_record_modification.pl b/tools/batch_record_modification.pl >index 60775a9..3aec4f7 100755 >--- a/tools/batch_record_modification.pl >+++ b/tools/batch_record_modification.pl >@@ -192,7 +192,8 @@ if ( $op eq 'form' ) { > my $error = eval { > my $record = GetMarcBiblio( $biblionumber ); > ModifyRecordWithTemplate( $mmtid, $record ); >- ModBiblio( $record, $biblionumber ); >+ my $frameworkcode = C4::Biblio::GetFrameworkCode( $biblionumber ); >+ ModBiblio( $record, $biblionumber, $frameworkcode ); > }; > if ( $error and $error != 1 or $@ ) { # ModBiblio returns 1 if everything as gone well > push @messages, { >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14795
:
44849
|
44856
|
44868