Bugzilla – Attachment 44871 Details for
Bug 15137
List email sent from staff is missing ISBN and author information
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15137: Display ISBN and author info when sending list by email
PASSED-QA-Bug-15137-Display-ISBN-and-author-info-w.patch (text/plain), 2.42 KB, created by
Katrin Fischer
on 2015-11-15 23:04:23 UTC
(
hide
)
Description:
[PASSED QA] Bug 15137: Display ISBN and author info when sending list by email
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-11-15 23:04:23 UTC
Size:
2.42 KB
patch
obsolete
>From 7f4023ebf3c2a61cc669394b262b21141de93a5f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 13 Nov 2015 15:18:56 +0000 >Subject: [PATCH] [PASSED QA] Bug 15137: Display ISBN and author info when > sending list by email > >Disclaimer: this is not caused by bug 14544 :) >And can be backported! > >Both isbn and author information are missing when a list is sent by >email. >Emails sent from OPAC and staff should be (almost) the same. > >Test plan: >1/ Sent a list by email (Button "Send list") >2/ The email you will receive should contain the isbn and author info > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >On top of last patch of Bug 14544 >Works ok, mail with authors and ISBN >No errors > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt | 2 +- > virtualshelves/sendshelf.pl | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt >index b70dac9..e63d6f5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt >@@ -56,7 +56,7 @@ Your list: [% shelfname %] > [% IF ( BIBLIO_RESULT.ISBN ) %] > <span> > ISBN: [% FOREACH isbn IN BIBLIO_RESULT.ISBN %] >- [% isbn.marcisbn %] >+ [% isbn %] > [% UNLESS ( loop.last ) %]; [% END %] > [% END %] > </span><br/> >diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl >index 9d10492..cb46ce2 100755 >--- a/virtualshelves/sendshelf.pl >+++ b/virtualshelves/sendshelf.pl >@@ -88,12 +88,14 @@ if ($email) { > > my @items = GetItemsInfo($biblionumber); > >+ $dat->{ISBN} = GetMarcISBN($record, $marcflavour); > $dat->{MARCNOTES} = $marcnotesarray; > $dat->{MARCSUBJCTS} = $marcsubjctsarray; > $dat->{MARCAUTHORS} = $marcauthorsarray; > $dat->{'biblionumber'} = $biblionumber; > $dat->{ITEM_RESULTS} = \@items; > $dat->{subtitle} = $subtitle; >+ $dat->{HASAUTHORS} = $dat->{'author'} || @$marcauthorsarray; > > $iso2709 .= $record->as_usmarc(); > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15137
:
44846
|
44862
| 44871