Bugzilla – Attachment 45722 Details for
Bug 14481
Warns when setting permissions for patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 14481: Warns when setting permissions for patron
SIGNED-OFF-Bug-14481-Warns-when-setting-permission.patch (text/plain), 1.38 KB, created by
Owen Leonard
on 2015-12-16 13:02:39 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 14481: Warns when setting permissions for patron
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2015-12-16 13:02:39 UTC
Size:
1.38 KB
patch
obsolete
>From aa9dcf90d22858b2d153567a7faa4d6d97922824 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Mon, 14 Dec 2015 22:26:20 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 14481: Warns when setting permissions for > patron >Content-Type: text/plain; charset="utf-8" > >Use of uninitialized value $roadtype > >To test: >1) Go to any patron page and click More --> Set permissions (or follow > this link --> > http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) >2) Notice the warns >3) Apply patch and reload page >4) Notice warns are gone and page still works correctly > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >This patch successfully eliminates the 'Use of uninitialized value >$roadtype' error in the log. >--- > members/member-flags.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/member-flags.pl b/members/member-flags.pl >index 1206f12..cfc28d1 100755 >--- a/members/member-flags.pl >+++ b/members/member-flags.pl >@@ -170,7 +170,7 @@ if (C4::Context->preference('ExtendedPatronAttributes')) { > > # Computes full borrower address > my $roadtype = C4::Koha::GetAuthorisedValueByCode( 'ROADTYPE', $bor->{streettype} ); >-my $address = $bor->{'streetnumber'} . " $roadtype " . $bor->{'address'}; >+my $address = $bor->{'streetnumber'} . ' $roadtype ' . $bor->{'address'}; > > $template->param( > borrowernumber => $bor->{'borrowernumber'}, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14481
:
40745
|
45678
| 45722