To recreate warns, go to any patron and click More --> Set permissions (ie follow this link http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/member-flags.pl line 176 member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/member-flags.pl line 176
Created attachment 40745 [details] [review] Bug 14481: Silences warns triggered when setting patron permissions Use of uninitialized value $roadtype To test: 1) Go to any patron page and click More --> Set permissions (or follow this link --> http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) 2) Notice the warns 3) Apply patch and reload page 4) Notice warns are gone and page still works correctly
I get less warns but still one: [Sat Jul 18 21:56:11.743502 2015] [cgi:error] [pid 13693] [client 127.0.0.1:37991] AH01215: [Sat Jul 18 21:56:11 2015] member-flags.pl: Use of uninitialized value in concatenation (.) or string at /home/nick/kohaclone/members/member-flags.pl line 177., referer: http://localhost:8080/cgi-bin/koha/members/moremember.pl?borrowernumber=19
Created attachment 45678 [details] [review] Bug 14481: Warns when setting permissions for patron Use of uninitialized value $roadtype To test: 1) Go to any patron page and click More --> Set permissions (or follow this link --> http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) 2) Notice the warns 3) Apply patch and reload page 4) Notice warns are gone and page still works correctly
Created attachment 45722 [details] [review] [SIGNED-OFF] Bug 14481: Warns when setting permissions for patron Use of uninitialized value $roadtype To test: 1) Go to any patron page and click More --> Set permissions (or follow this link --> http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) 2) Notice the warns 3) Apply patch and reload page 4) Notice warns are gone and page still works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> This patch successfully eliminates the 'Use of uninitialized value $roadtype' error in the log.
I have not tested, but it cannot work. It will remove the warning, but $roadtype won't be interpret as a variable but as a string :) The consequence is that the address displayed will be "12 $roadtype patron address"
Is it possible we could just remove $roadtype from the details page? I tested having information in every address field and it didn't appear to use $roadtype until I clicked Set permissions. Where does $roadtype actually get used here?
$roadtype might only appear if you have the authorized value for it set up - it's an older feature that was moved into a system preference a few versions ago. It gives you a pull down for the 'road type' for patron's addresses.
Which syspref Katrin? I can't seem to see it
Ah sorry... I meant an authorised value... try adding something like: ROADTYPE - S - Street. When you check your edit patron screen then, it should have changed.
So this warn only shows up when no authorized value has been chosen for roadtype. I've found ways to make the warn disappear, but then it doesn't display the roadtype in the address where it should. Any suggestions for a patch?
I am not sure it makes sense to remove this warning, it happens if there is a configuration issue. Moreover, there is something wrong with the display of the roadtype in the address. I am going to open a bug report.
This warning will be removed by bug 15542. *** This bug has been marked as a duplicate of bug 15542 ***