Attachment 46246 Details for Bug 15466 – Bug 15466: Do not assume $values_in is a hashref

[patch] Bug 15466: Do not assume $values_in is a hashref

Bug-15466-Do-not-assume-valuesin-is-a-hashref.patch (text/plain), 1.06 KB, created by Marc Véron on 2016-01-05 09:50:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2016-01-05 09:50:01 UTC

Size: 1.06 KB

patch

obsolete

>From 60fa960fa308b0e941cca846c5145978c7e8018c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 5 Jan 2016 09:39:32 +0000
>Subject: [PATCH] Bug 15466: Do not assume $values_in is a hashref
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>It could be undefined.
>Test plan:
>prove t/db_dependent/Suggestions.t
>should return green.
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> C4/Letters.pm |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index e5c15ba..dc9574f 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -803,7 +803,7 @@ sub _parseletter {
> 
>     # Work on a local copy of $values_in (passed by reference) to avoid side effects
>     # in callers ( by changing / formatting values )
>-    my $values = { %$values_in };
>+    my $values = $values_in ? { %$values_in } : {};
> 
>     if ( $table eq 'borrowers' && $values->{'dateexpiry'} ){
>         $values->{'dateexpiry'} = format_sqldatetime( $values->{'dateexpiry'} );
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 15466: 46244 | 46246 | 46349