Bug 15466 - Suggestions.t is failing
Summary: Suggestions.t is failing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 15429
Blocks:
  Show dependency tree / graph
 
Reported: 2016-01-05 09:39 UTC by Jonathan Druart
Modified: 2017-06-14 22:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 15466: Do not assume $values_in is a hashref (940 bytes, patch)
2016-01-05 09:40 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 15466: Do not assume $values_in is a hashref (1.06 KB, patch)
2016-01-05 09:50 UTC, Marc Véron 		Details | Diff | Splinter Review
[PASSED QA] Bug 15466: Do not assume $values_in is a hashref (1.12 KB, patch)
2016-01-06 20:14 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-01-05 09:39:29 UTC 

    


    


      

          
            
          


        
          Comment 1
        

        
          Jonathan Druart

        

        
        

        
          2016-01-05 09:40:42 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      

          
            
          


        
          Comment 2
        

        
          Marc Véron

        

        
        

        
          2016-01-05 09:50:01 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 3
        

        
          Katrin Fischer

        

        
        

        
          2016-01-06 20:14:28 UTC
        

      






Created attachment 46349 [details] [review]
[PASSED QA] Bug 15466: Do not assume $values_in is a hashref

It could be undefined.
Test plan:
prove t/db_dependent/Suggestions.t
should return green.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

    


    


      



        
          Comment 4
        

        
          Brendan Gallagher

        

        
        

        
          2016-01-07 19:25:20 UTC
        

      






Pushed to Master - thanks

    


    


      



        
          Comment 5
        

        
          Julian Maurice

        

        
        

        
          2016-01-12 13:55:54 UTC
        

      






Patch pushed to 3.22.x, will be in 3.22.2