Attachment 46344 Details for Bug 15469 – Bug 15469: Fix authority header search

[patch] Bug 15469: Fix authority header search

0001-Bug-15469-Fix-authority-header-search.patch (text/plain), 3.54 KB, created by Julian Maurice on 2016-01-06 18:24:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2016-01-06 18:24:18 UTC

Size: 3.54 KB

patch

obsolete

>From d9cbac2174726c5a613bbfdeda9534921af7ab56 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 5 Jan 2016 10:49:31 +0000
>Subject: [PATCH] Bug 15469: Fix authority header search
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Introduced by bug 15381.
>
>The logs contain plenty of "detail.pl: No method value!" and the
>dropwdown list is not correctly populated (no value for options)
>
>Test plan:
>Go to the authority module and have a look at the auth type codes
>dropdown list.
>Without this patch, the values of the options are empty.
>With this patch, the values are correctly filled.
>
>Signed-off-by: FrÃ©dÃ©ric Demians <f.demians@tamil.fr>
>  I confirm this patch silence noise in log file.
>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> .../intranet-tmpl/prog/en/includes/authorities-search.inc    | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
>index 9be4ee0..164e20f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
>@@ -27,9 +27,9 @@
>         [% IF (marcflavour == 'UNIMARC' ) %]<option value="">All authority types</option>[% END %]
>         [% FOREACH authority_type IN authority_types %]
>             [% IF authority_type.authtypecode == authtypecode %]
>-            <option value="[% authority_type.value %]" selected="selected">[% authority_type.authtypetext %]</option>
>+            <option value="[% authority_type.authtypecode%]" selected="selected">[% authority_type.authtypetext %]</option>
>             [% ELSE %]
>-            <option value="[% authority_type.value %]">[% authority_type.authtypetext %]</option>
>+            <option value="[% authority_type.authtypecode %]">[% authority_type.authtypetext %]</option>
>             [% END %]
>         [% END %]
>         </select>
>@@ -83,9 +83,9 @@
>         [% IF (marcflavour == 'UNIMARC' ) %]<option value="">All authority types</option>[% END %]
>         [% FOREACH authority_type IN authority_types %]
>             [% IF authority_type.authtypecode == authtypecode %]
>-            <option value="[% authority_type.value %]" selected="selected">[% authority_type.authtypetext %]</option>
>+            <option value="[% authority_type.authtypecode %]" selected="selected">[% authority_type.authtypetext %]</option>
>             [% ELSE %]
>-            <option value="[% authority_type.value %]">[% authority_type.authtypetext %]</option>
>+            <option value="[% authority_type.authtypecode %]">[% authority_type.authtypetext %]</option>
>             [% END %]
>         [% END %]
>         </select>
>@@ -139,9 +139,9 @@
>         [% IF (marcflavour == 'UNIMARC' ) %]<option value="">All authority types</option>[% END %]
>         [% FOREACH authority_type IN authority_types %]
>             [% IF authority_type.authtypecode == authtypecode %]
>-            <option value="[% authority_type.value %]" selected="selected">[% authority_type.authtypetext %]</option>
>+            <option value="[% authority_type.authtypecode %]" selected="selected">[% authority_type.authtypetext %]</option>
>             [% ELSE %]
>-            <option value="[% authority_type.value %]">[% authority_type.authtypetext %]</option>
>+            <option value="[% authority_type.authtypecode %]">[% authority_type.authtypetext %]</option>
>             [% END %]
>         [% END %]
>         </select>
>-- 
>1.9.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 15469: 46248 | 46249 | 46344 | 46383 | 46468 | 46469