Bug 15469 - Authority header search is broken
Summary: Authority header search is broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 15381
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-05 10:49 UTC by Jonathan Druart
Modified: 2016-12-05 21:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15469: Fix authority header search (3.29 KB, patch)
2016-01-05 10:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15469: Fix authority header search (3.48 KB, patch)
2016-01-05 11:32 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 15469: Fix authority header search (3.54 KB, patch)
2016-01-06 18:24 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 15469: Same fix for the "entire record" tab (1.63 KB, patch)
2016-01-07 08:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 15469: Fix authority header search (3.61 KB, patch)
2016-01-10 23:33 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 15469: Same fix for the "entire record" tab (1.69 KB, patch)
2016-01-10 23:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-01-05 10:49:54 UTC
Introduced by bug 15381.

The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options).
Comment 1 Jonathan Druart 2016-01-05 10:51:38 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2016-01-05 11:32:05 UTC Comment hidden (obsolete)
Comment 3 Julian Maurice 2016-01-06 18:20:02 UTC
I was just about to file a new bug for this. I confirm that the patch solves the issue.
Comment 4 Julian Maurice 2016-01-06 18:24:18 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2016-01-06 20:07:58 UTC
Hm, this is not quite working for me. I see the same with and without the patch:

MARC21 installation.

Staff > Authorities

Switching tabs in the search bar:
  Search entire record - pull down remains empty
  All other tabs - pull down is filled
Comment 6 Jonathan Druart 2016-01-07 08:30:18 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2016-01-07 21:46:40 UTC
Almost there - just one small inconsistency - the last tab shows the 'chronological term' preselected, while all others show 'default'.
Can you take a quick look if that's an easy fix?
Comment 8 Jonathan Druart 2016-01-08 09:22:52 UTC
(In reply to Katrin Fischer from comment #7)
> Almost there - just one small inconsistency - the last tab shows the
> 'chronological term' preselected, while all others show 'default'.
> Can you take a quick look if that's an easy fix?

I have Default preselected for the 4 tabs.
Are you sure it comes from this patch?
Comment 9 Katrin Fischer 2016-01-08 09:27:50 UTC
Hm not sure what else it could, but will retest.
Comment 10 Katrin Fischer 2016-01-10 23:31:56 UTC
It looks like you are right - it was wrong before!
Comment 11 Katrin Fischer 2016-01-10 23:33:58 UTC
Created attachment 46468 [details] [review]
[PASSED QA] Bug 15469: Fix authority header search

Introduced by bug 15381.

The logs contain plenty of "detail.pl: No method value!" and the
dropwdown list is not correctly populated (no value for options)

Test plan:
Go to the authority module and have a look at the auth type codes
dropdown list.
Without this patch, the values of the options are empty.
With this patch, the values are correctly filled.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  I confirm this patch silence noise in log file.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Katrin Fischer 2016-01-10 23:34:28 UTC
Created attachment 46469 [details] [review]
[PASSED QA] Bug 15469: Same fix for the "entire record" tab

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Brendan Gallagher 2016-01-14 17:08:40 UTC
Pushed to Master - Should be in the May 2016 release
Comment 14 Julian Maurice 2016-01-15 08:17:25 UTC
Does not concern stable versions, changing status to RESOLVED