Bugzilla – Attachment 46377 Details for
Bug 15119
Hide search header text boxes on render
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 15119: Hide search header text boxes on render
SIGNED-OFFBug-15119-Hide-search-header-text-boxes-.patch (text/plain), 2.50 KB, created by
Héctor Eduardo Castro Avalos
on 2016-01-06 23:33:42 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 15119: Hide search header text boxes on render
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-01-06 23:33:42 UTC
Size:
2.50 KB
patch
obsolete
>From fd933d579777f7f8951738bfbb34e1faaa8bb0d2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 6 Jan 2016 13:10:00 +0000 >Subject: [PATCH] [SIGNED-OFF]Bug 15119: Hide search header text boxes on > render > >When the page rendering is slow or the page is heavy, the tabs in the >header shown be not correctly displayed as tabs. > >This patch suggests to hide them, display the first one, and wait for >the JS code to display them nicely. > >To easily reproduced the ergonomic issue, go on the circulation home >page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or >'d', you will get a lot of result and the page will be slow to be fully >displayed. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised >--- > koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css | 9 +++++++++ > koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js | 2 ++ > 2 files changed, 11 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >index b35e6be..036db14 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >@@ -2245,6 +2245,15 @@ ul.ui-tabs-nav li { > border-radius: 0 0 4px 4px; > } > >+#header_search > div, >+#header_search > ul > li { >+ display: none; >+} >+#header_search > div:first-of-type, >+#header_search > ul > li:first-of-type { >+ display: block; >+} >+ > .authref { > font-style: normal; > text-indent: 4em; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js >index 92ba935..065f21d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js >@@ -33,6 +33,8 @@ $.fn.selectTabByID = function (tabID) { > if($("#header_search #circ_search").length > 0){ shortcut.add('Alt+u',function (){ $("#header_search").selectTabByID("#circ_search"); $("#findborrower").focus(); }); } else { shortcut.add('Alt+u',function(){ location.href="/cgi-bin/koha/circ/circulation.pl"; }); } > if($("#header_search #catalog_search").length > 0){ shortcut.add('Alt+q',function (){ $("#header_search").selectTabByID("#catalog_search"); $("#search-form").focus(); }); } else { shortcut.add('Alt+q',function(){ location.href="/cgi-bin/koha/catalogue/search.pl"; }); } > >+ $("#header_search > ul > li").show(); >+ > $(".focus").focus(); > $(".validated").each(function() { > $(this).validate(); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15119
:
46325
|
46377
|
48965
|
48988
|
49344