Bugzilla – Attachment 46418 Details for
Bug 14571
using_https check for ssl connections doesn't work in some situations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14571: using_https check for ssl connections doesn't work in some situations
Bug-14571-usinghttps-check-for-ssl-connections-doe.patch (text/plain), 3.58 KB, created by
Jonathan Druart
on 2016-01-08 10:38:47 UTC
(
hide
)
Description:
Bug 14571: using_https check for ssl connections doesn't work in some situations
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-01-08 10:38:47 UTC
Size:
3.58 KB
patch
obsolete
>From e7da230a51a1389f1a856d4ec0b3015c7fd36eca Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Tue, 21 Jul 2015 10:41:02 +1200 >Subject: [PATCH] Bug 14571: using_https check for ssl connections doesn't work > in some situations > >To test: > >* turn on Amazon images for result and detail in the OPAC >* do a search that will result in an Amazon image being displayed on the > result page >* inspect the cover image that is returned on the result page, it should > be using a https://images-na... Amazon URL. >* click through to the detail for that item >* inspect the cover image that is returned on the detail page, it should > be using a https://images-na... Amazon URL. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ---- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 ---- > 2 files changed, 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 3b5c404..2b5a730 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -58,11 +58,7 @@ > [% ELSE %] > <a href="http://www.amazon[% AmazonTld %]/dp/[% normalized_isbn %]"> > [% END %] >- [% IF ( using_https ) %] > <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover image" /></a> >- [% ELSE %] >- <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover image" /></a> >- [% END %] > [% END %] > > [% IF ( SyndeticsEnabled && SyndeticsCoverImages ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 8a0ec89..f2c3d7d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -240,11 +240,7 @@ > [% END %] > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( SEARCH_RESULT.normalized_isbn ) %] >- [% IF ( using_https ) %] > <span title="[% SEARCH_RESULT.biblionumber %]" id="amazon-thumbnail[% loop.count %]"><img src="https://images-na.ssl-images-amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="item-thumbnail" /></span> >- [% ELSE %] >- <span title="[% SEARCH_RESULT.biblionumber %]" id="amazon-thumbnail[% loop.count %]"><img src="http://images.amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="item-thumbnail" /></span> >- [% END %] > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14571
:
41100
|
41101
|
41102
|
46229
|
46230
|
46231
| 46418 |
46419
|
46420
|
46421
|
51640