Bugzilla – Attachment 46421 Details for
Bug 14571
using_https check for ssl connections doesn't work in some situations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14571 - Intranet detail needs ssl sources for Amazon images
Bug-14571---Intranet-detail-needs-ssl-sources-for-.patch (text/plain), 2.23 KB, created by
Jonathan Druart
on 2016-01-08 10:38:58 UTC
(
hide
)
Description:
Bug 14571 - Intranet detail needs ssl sources for Amazon images
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-01-08 10:38:58 UTC
Size:
2.23 KB
patch
obsolete
>From 8c92ebbc082e61535c0d64c76cacbbc7f06c93eb Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Fri, 8 Jan 2016 11:23:38 +1300 >Subject: [PATCH] Bug 14571 - Intranet detail needs ssl sources for Amazon > images > >To test: > >Enable Amazon images for the staff client - syspref: AmazonCoverImages -> Show >Go to a record detail in the intranet that has an Amazon image, inspect it, and make sure that it > >1. Shows >2. has https://images-na. and not http://images. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 8 -------- > 1 file changed, 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index f2fb6e2..4fca8dd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -388,11 +388,7 @@ function verify_images() { > [% IF ( AmazonCoverImages ) %] > <div id="amazon-bookcoverimg"> > <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"> >- [% IF ( using_https ) %] > <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> >- [% ELSE %] >- <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> >- [% END %] > </a></div> > [% END %] > [% END %] >@@ -466,11 +462,7 @@ function verify_images() { > [% IF ( AmazonCoverImages ) %] > <div id="amazon-bookcoverimg"> > <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"> >- [% IF ( using_https ) %] > <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> >- [% ELSE %] >- <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="" /> >- [% END %] > </a> > </div> > [% END %] >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14571
:
41100
|
41101
|
41102
|
46229
|
46230
|
46231
|
46418
|
46419
|
46420
| 46421 |
51640