Attachment 46712 Details for Bug 15578 – Bug 15578: Make sure all params will be taken into account when instantiating

[patch] Bug 15578: Make sure all params will be taken into account when instantiating

Bug-15578-Make-sure-all-params-will-be-taken-into-.patch (text/plain), 1.54 KB, created by Kyle M Hall (khall) on 2016-01-15 16:41:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2016-01-15 16:41:41 UTC

Size: 1.54 KB

patch

obsolete

>From f347f5d10329f9a143038a33623843be2b1127b7 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 14 Jan 2016 12:27:55 +0000
>Subject: [PATCH] Bug 15578: Make sure all params will be taken into account
> when instantiating
>
>The tests in t/db_dependent/Koha_Authority.t expects at least 1
>authority record in the DB to run them, otherwise they are skipped.
>On our integration server, the DB does not contain any records, and the
>tests are skipped.
>Unfortunately these tests were testing the authid method of
>Koha::MetadataRecord::Authority.
>
>Test plan:
>Apply the first patch, launch tests
>=> Fail
>Apply the second patch, launch tests
>=> \o/
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Test pass successfuly
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/MetadataRecord.pm | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
>diff --git a/Koha/MetadataRecord.pm b/Koha/MetadataRecord.pm
>index 1577cd0..1b2f4aa 100644
>--- a/Koha/MetadataRecord.pm
>+++ b/Koha/MetadataRecord.pm
>@@ -87,17 +87,8 @@ sub new {
>         return;
>     }
> 
>-    my $record = $params->{ record };
>-    my $schema = $params->{ schema };
>-    my $format = $params->{ format } // 'MARC';
>-    my $id     = $params->{ id };
>-
>-    my $self = $class->SUPER::new({
>-        record => $record,
>-        schema => $schema,
>-        format => $format,
>-        id     => $id
>-    });
>+    $params->{format} //= 'MARC';
>+    my $self = $class->SUPER::new($params);
> 
>     bless $self, $class;
>     return $self;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15578: 46649 | 46650 | 46675 | 46676 | 46711 | 46712 | 47638 | 47639 | 48156 | 48157