The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority.
Created attachment 46649 [details] [review] Bug 15578: Insert authority records before processing tests
Created attachment 46650 [details] [review] Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/
Created attachment 46675 [details] [review] [SIGNED-OFF]Bug 15578: Insert authority records before processing tests Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Created attachment 46676 [details] [review] [SIGNED-OFF]Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successfuly
Created attachment 46711 [details] [review] Bug 15578: Insert authority records before processing tests Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 46712 [details] [review] Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successfuly Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the May 2016 release. Thanks!
This bug does not concern stable versions, changing status to RESOLVED
Actually those patches are needed for bug 15358. Reopening...
Created attachment 47638 [details] [review] [3.22.x] Bug 15578: Insert authority records before processing tests
Created attachment 47639 [details] [review] [3.22.x] Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/
Original patches don't apply well on 3.22.x, so here are the patches for 3.22. If someone else can test and signoff them, that would be great :)
It looks like we need a sign-off on the patches on 15578 in order to get this into 3.22.
I think I'll push these patches even without a signoff, because it blocks bug 15358 which is a "blocker". Moreover, 15358's patch for 3.22 has been signed off, which mean this bug's patches kind of work too :) That being said, I would still like those patches to be signed off before I push them ;) (probably tomorrow or the day after)
Created attachment 48156 [details] [review] [3.22.x] Bug 15578: Insert authority records before processing tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48157 [details] [review] [3.22.x] Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Let's sign my own patches off...
Patches pushed to 3.22.x, will be in 3.22.4 Thanks Jonathan