Attachment 47488 Details for Bug 15645 – Bug 15645 - In transit holds do not show as in transit on request.pl

[patch] Bug 15645 - In transit holds do not show as in transit on request.pl

Bug-15645---In-transit-holds-do-not-show-as-in-tra.patch (text/plain), 1.45 KB, created by Marc Véron on 2016-02-01 08:39:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2016-02-01 08:39:53 UTC

Size: 1.45 KB

patch

obsolete

>From c00bc2dfd104870c9964035cbab609ddf8f2252f Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 22 Jan 2016 16:36:26 +0000
>Subject: [PATCH] Bug 15645 - In transit holds do not show as in transit on
> request.pl
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>A hold in transit will simply appear as an unfilled hold!
>
>Test Plan:
>1) Place a hold for pickup at a different location
>2) Capture that hold for a patron
>3) Note you do not see the in transit status on request.pl
>4) Apply this patch
>5) Refresh the page
>6) The hold should now show as in transit!
>
>Followed test plan, works as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> reserve/request.pl |    1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/reserve/request.pl b/reserve/request.pl
>index dfdd6e1..3b37cac 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -551,7 +551,6 @@ foreach my $biblionumber (@biblionumbers) {
>         $reserve{'firstname'}      = $res->borrower()->firstname();
>         $reserve{'surname'}        = $res->borrower()->surname();
>         $reserve{'notes'}          = $res->reservenotes();
>-        $reserve{'wait'}           = $res->is_waiting();
>         $reserve{'waiting_date'}   = $res->waitingdate();
>         $reserve{'waiting_until'}  = $res->is_waiting() ? $res->waiting_expires_on() : undef;
>         $reserve{'ccode'}          = $res->item() ? $res->item()->ccode() : undef;
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 15645: 47197 | 47488 | 47502 | 47503 | 47595