Bug 15645 - In transit holds do not show as in transit on request.pl
Summary: In transit holds do not show as in transit on request.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-22 16:35 UTC by Kyle M Hall
Modified: 2019-06-27 09:24 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15645 - In transit holds do not show as in transit on request.pl (1.27 KB, patch)
2016-01-22 16:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15645 - In transit holds do not show as in transit on request.pl (1.45 KB, patch)
2016-02-01 08:39 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15645 - In transit holds do not show as in transit on request.pl (1.51 KB, patch)
2016-02-01 13:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15645: Remove the confusing wait var and use found instead (3.63 KB, patch)
2016-02-01 13:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15645: Remove the confusing wait var and use found instead (3.69 KB, patch)
2016-02-03 14:50 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2016-01-22 16:35:23 UTC
A hold in transit will simply appear as an unfilled hold!
Comment 1 Kyle M Hall 2016-01-22 16:37:45 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-01 08:39:53 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-01 13:08:43 UTC
Created attachment 47502 [details] [review]
Bug 15645 - In transit holds do not show as in transit on request.pl

A hold in transit will simply appear as an unfilled hold!

Test Plan:
1) Place a hold for pickup at a different location
2) Capture that hold for a patron
3) Note you do not see the in transit status on request.pl
4) Apply this patch
5) Refresh the page
6) The hold should now show as in transit!

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2016-02-01 13:10:11 UTC
The code in this area (found/wait/transit) is really confusing.
When you read it, this patch does not make sense, but the variable names are not correct in the pl/template and finally it fixes the issue!
Comment 5 Jonathan Druart 2016-02-01 13:13:24 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2016-02-01 13:14:01 UTC
Kyle, could you have a look at my follow-up please?
It seems that it fixes the confusion.
Comment 7 Kyle M Hall 2016-02-03 14:50:04 UTC
Created attachment 47595 [details] [review]
Bug 15645: Remove the confusing wait var and use found instead

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Kyle M Hall 2016-02-03 14:50:32 UTC
(In reply to Jonathan Druart from comment #6)
> Kyle, could you have a look at my follow-up please?
> It seems that it fixes the confusion.

Looks good!
Comment 9 Brendan Gallagher 2016-02-22 20:58:03 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks
Comment 10 Julian Maurice 2016-02-26 11:39:07 UTC
Following test plan on 3.22.x, at step 3 I see "Item being transferred to ..." in reserve/request.pl table. Does it mean that this patch is not needed in 3.22 ?
Comment 11 Julian Maurice 2016-03-14 10:06:17 UTC
Does not concern stable versions, status changed to RESOLVED