Bugzilla – Attachment 4841 Details for
Bug 5713
Intranet - Circulation - Fines : debug calculation when fines are reversed then re-payed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch (passed QA)
0001-debug-calculation-when-fines-are-reversed-then-re-pa.patch (text/plain), 2.97 KB, created by
Paul Poulain
on 2011-08-04 13:08:24 UTC
(
hide
)
Description:
proposed patch (passed QA)
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2011-08-04 13:08:24 UTC
Size:
2.97 KB
patch
obsolete
>From 424ecdaba42a6f124207c7ebb72ff85ca624fc49 Mon Sep 17 00:00:00 2001 >From: Brice Sanchez <brice.sanchez@sys-tech.net> >Date: Tue, 8 Feb 2011 13:01:46 -0500 >Subject: [PATCH] debug calculation when fines are reversed then re-payed > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> > >I could not reproduce the calculation bug, but after >applying this patch multiple pay/reverse cycles only >are still only 2 lines in accountlines, which makes the >display a lot less confusing. >Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> >--- > C4/Accounts.pm | 56 +++++++++++++++++++++++++++++++++++--------------------- > 1 files changed, 35 insertions(+), 21 deletions(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index 3275099..334ac70 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -169,27 +169,41 @@ sub makepayment { > my $data = $sth->fetchrow_hashref; > $sth->finish; > >- $sth = $dbh->prepare("UPDATE accountlines >- SET amountoutstanding = 0 >- WHERE borrowernumber = ? >- AND accountno = ?"); >- $sth->execute($borrowernumber, $accountno); >- >- # print $updquery; >-# $dbh->do( " >-# INSERT INTO accountoffsets >-# (borrowernumber, accountno, offsetaccount, >-# offsetamount) >-# VALUES ($borrowernumber, $accountno, $nextaccntno, $newamtos) >-# " ); >- >- # create new line >- my $payment = 0 - $amount; >- $sth = $dbh->prepare("INSERT INTO accountlines >- (borrowernumber, accountno, date, amount, >- description, accounttype, amountoutstanding) >- VALUES (?,?,now(),?,?,'Pay',0)"); >- $sth->execute($borrowernumber, $nextaccntno, $payment, "Payment,thanks - $user"); >+ if($data->{'accounttype'} eq "Pay"){ >+ my $udp = >+ $dbh->prepare( >+ "UPDATE accountlines >+ SET amountoutstanding = 0, description = 'Payment,thanks' >+ WHERE borrowernumber = ? >+ AND accountno = ? >+ " >+ ); >+ $udp->execute($borrowernumber, $accountno ); >+ $udp->finish; >+ }else{ >+ my $udp = >+ $dbh->prepare( >+ "UPDATE accountlines >+ SET amountoutstanding = 0 >+ WHERE borrowernumber = ? >+ AND accountno = ? >+ " >+ ); >+ $udp->execute($borrowernumber, $accountno ); >+ $udp->finish; >+ >+ # create new line >+ my $payment = 0 - $amount; >+ >+ my $ins = >+ $dbh->prepare( >+ "INSERT >+ INTO accountlines (borrowernumber, accountno, date, amount, description, accounttype, amountoutstanding) >+ VALUES ( ?, ?, now(), ?, 'Payment,thanks', 'Pay', 0)" >+ ); >+ $ins->execute($borrowernumber, $nextaccntno, $payment); >+ $ins->finish; >+ } > > # FIXME - The second argument to &UpdateStats is supposed to be the > # branch code. >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5713
:
3092
|
3098
|
4215
| 4841