Bugzilla – Attachment 48479 Details for
Bug 15916
Regression: Many tables' sorting broken by JavaScript error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15916: Datatables - buttons area should be defined
PASSED-QA-Bug-15916-Datatables---buttons-area-shou.patch (text/plain), 1.60 KB, created by
Katrin Fischer
on 2016-02-29 22:49:03 UTC
(
hide
)
Description:
[PASSED QA] Bug 15916: Datatables - buttons area should be defined
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-02-29 22:49:03 UTC
Size:
1.60 KB
patch
obsolete
>From 76680d481409e974c3ddef01e7303546491c47df Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 29 Feb 2016 08:34:46 +0000 >Subject: [PATCH] [PASSED QA] Bug 15916: Datatables - buttons area should be > defined > >Commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b > Bug 15285: Update common files > >Set 'B' to the default dom of Datatable constructor. >This cannot work if there is no button defined. > >This patch defined an empty 'buttons' param for this constructor, DT >does not raised an error anymore when initialising. > >Test plan: >Confirm that the tables on the following tables are not broken: >- circ/waitingreserves.pl >- circ/reserveratios.pl >- patron_lists/lists.pl >- virtualshelves/shelves.pl >- acqui/invoices.pl >And with datatables: >- circ/circulation.pl >- admin/currency.pl > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/js/datatables.js | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js >index 71185c6..fd9dfd2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/datatables.js >@@ -24,6 +24,7 @@ var dataTablesDefaults = { > "sZeroRecords" : window.MSG_DT_ZERO_RECORDS || "No matching records found" > }, > "dom": '<"top pager"ilpfB>tr<"bottom pager"ip>', >+ "buttons": [], > "aLengthMenu": [[10, 20, 50, 100, -1], [10, 20, 50, 100, window.MSG_DT_ALL || "All"]], > "iDisplayLength": 20 > }; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15916
:
48431
|
48432
| 48479