Bugzilla – Attachment 48552 Details for
Bug 15672
Show descriptions instead of codes on the hold ratios report
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 15672 - Show descriptions instead of codes on the hold ratios report
SIGNED-OFF-Bug-15672---Show-descriptions-instead-o.patch (text/plain), 3.14 KB, created by
Nicole C. Engard
on 2016-03-02 16:58:38 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 15672 - Show descriptions instead of codes on the hold ratios report
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2016-03-02 16:58:38 UTC
Size:
3.14 KB
patch
obsolete
>From 49aef7ef7a1c6f41c9e3ed9094cdd6ff9a76ab85 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 17 Feb 2016 18:47:52 -0500 >Subject: [PATCH] [SIGNED-OFF] Bug 15672 - Show descriptions instead of codes > on the hold ratios report > >This patch revises the hold ratios report so that it uses template >plugins to display descriptions instead of codes for item holding >branch, item home branch, item type, and library name. > >To test you should have multiple items on the hold ratio report (set the >ratio to a small number to increase the number of results). It should >include one or more items which have a shelving location set. > >View the hold ratios report and confirm that library names, shelving >location descriptions, and item type descriptions are shown instead of >codes. > >Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >index 67f4226..4ad8821 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >@@ -1,4 +1,7 @@ > [% USE KohaDates %] >+[% USE AuthorisedValues %] >+[% USE Branches %] >+[% USE ItemTypes %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Circulation › Hold ratios</title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -72,10 +75,10 @@ > <td><p class="ratiolimit">[% reserveloo.thisratio %]</p></td> > <td> [% INCLUDE 'biblio-default-view.inc' biblionumber = reserveloo.biblionumber %][% reserveloo.title |html %] [% IF ( reserveloo.subtitle ) %][% FOREACH subtitl IN reserveloo.subtitle %][% subtitl.subfield %][% END %][% END %]</a>[% IF ( reserveloo.author ) %] by [% reserveloo.author %][% END %] > </td> >- <td><p>[% reserveloo.homebranch_list %]</p></td> >- <td><p>[% reserveloo.holdingbranch_list %]</p></td> >- <td><p>[% reserveloo.location %]</p></td> >- <td><p>[% reserveloo.itype %]</p></td> >+ <td><p>[% Branches.GetName( reserveloo.homebranch_list ) %]</p></td> >+ <td><p>[% Branches.GetName( reserveloo.holdingbranch_list ) %]</p></td> >+ <td><p>[% AuthorisedValues.GetByCode( 'LOC', reserveloo.location )%]</p></td> >+ <td><p>[% ItemTypes.GetDescription( reserveloo.itype ) %]</p></td> > <td><p>[% reserveloo.listcall %]</p></td> > <td>[% IF ( reserveloo.thisratio_atleast1 ) %]<p>[% IF ( CAN_user_acquisition && basketno && booksellerid ) %]<!-- [% reserveloo.ratiocalc %] --><a href="/cgi-bin/koha/acqui/neworderempty.pl?biblionumber=[% reserveloo.biblionumber %]&booksellerid=[% booksellerid %]&basketno=[% basketno %]&rr_quantity_to_order=[% reserveloo.ratiocalc %]">[% END %]<b>[% reserveloo.ratiocalc %] to order</b>[% IF ( CAN_user_acquisition && basketno && booksellerid ) %]</a>[% END %] > [% IF ( reserveloo.pendingorders ) %]<br><b>[% reserveloo.pendingorders %] pending</b>[% END %]</p>[% END %]</td> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15672
:
48200
|
48552
|
49228
|
49234
|
49241
|
49242