Bugzilla – Attachment 49202 Details for
Bug 16077
Remove unused script and template card-print
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16077 - Remove unused script and template card-print
Bug-16077---Remove-unused-script-and-template-card.patch (text/plain), 17.27 KB, created by
Jonathan Druart
on 2016-03-16 09:08:39 UTC
(
hide
)
Description:
Bug 16077 - Remove unused script and template card-print
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-03-16 09:08:39 UTC
Size:
17.27 KB
patch
obsolete
>From 2ba497e237b482e3c2956a04b7b903da2a276270 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 15 Mar 2016 10:02:22 -0400 >Subject: [PATCH] Bug 16077 - Remove unused script and template card-print >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >I can find no reference to card-print.pl being used in Koha. This patch >deletes it and its associated template. > >To test, apply the patch and search for references to "card-print" in >Koha. There should be none. > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >This script does not work, it fails with 'Undefined subroutine >get_label_output_formats'. This subroutine was in C4::Labels::Lib which >has been removed by 2433a91 (Feb 8 2010): Removing depricated file from the >C4::Labels module. >--- > .../prog/en/modules/patroncards/card-print.tt | 165 --------------------- > patroncards/card-print.pl | 131 ---------------- > 2 files changed, 296 deletions(-) > delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/card-print.tt > delete mode 100755 patroncards/card-print.pl > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/card-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/card-print.tt >deleted file mode 100644 >index a2b9ef9..0000000 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/card-print.tt >+++ /dev/null >@@ -1,165 +0,0 @@ >- [% INCLUDE 'doc-head-open.inc' %] >- <title>Koha › Tools › Patron Card Creator › Patron card printing/exporting</title> >- [% INCLUDE 'doc-head-close.inc' %] >- <script type="text/JavaScript" language="JavaScript"> >- //<![CDATA[ >- function Done() { >- window.location = "[% referer %]"; >- }; >- //]]> >- </script> >- <style type="text/css">#custom-doc {width:47.23em; *width:46.04em; min-width:610px; margin:auto; margin-top:0.4em;}</style> >- <style type="text/css">table {border-collapse: separate; border-spacing: 0; border: hidden none;} .header {cursor: auto; background-position: center center; background-repeat: repeat;}</style> >-</head> >-<body id="pcard_card-print" class="tools pcard"> >- <div id="custom-doc" class="yui-t2"> >- <div id="bd"> >- [% IF ( batches ) %] >- <form> >- <div align="center"> >- <div class="message"> >- <b>Click on the following link(s) to download the exported batch(es).</b> >- </div> >- </div> >- <fieldset class="rows"> >- <table class="borderless"> >- [% FOREACH batche IN batches %] >- <tr> >- [% IF ( batche.label_ids ) %] >- <td class="borderless"> >- [% batche.label_count %] Single cards >- </td> >- <td class="borderless"> >- <h1 id="pdf"> >- <a href="/cgi-bin/koha/labels/[% batche.create_script %]?batch_id=[% batche.batch_id %]&template_id=[% batche.template_id %]&layout_id=[% batche.layout_id %]&start_label=[% batche.start_label %][% batche.label_ids %]">label_single_[% batche.label_count %].pdf</a> >- </h1> >- </td> >- <td class="borderless"> >- <h1 id="csv"> >- <a href="/cgi-bin/koha/labels/label-create-csv.pl?batch_id=[% batche.batch_id %]&template_id=[% batche.template_id %]&layout_id=[% batche.layout_id %][% batche.label_ids %]">label_single_[% batche.label_count %].csv</a> >- </h1> >- </td> >- <td class="borderless"> >- <h1 id="xml"> >- <a href="/cgi-bin/koha/labels/label-create-xml.pl?batch_id=[% batche.batch_id %]&template_id=[% batche.template_id %]&layout_id=[% batche.layout_id %][% batche.label_ids %]">label_single_[% batche.label_count %].xml</a> >- </h1> >- </td> >- [% ELSIF ( batche.item_numbers ) %] >- <td class="borderless"> >- [% batche.label_count %] Single Cards >- </td> >- <td class="borderless"> >- <h1 id="pdf"> >- <a href="/cgi-bin/koha/labels/[% batche.create_script %]?template_id=[% batche.template_id %]&layout_id=[% batche.layout_id %]&start_label=[% batche.start_label %][% batche.item_numbers %]">label_single_[% batche.label_count %].pdf</a> >- </h1> >- </td> >- <td class="borderless"> >- <h1 id="csv"> >- <a href="/cgi-bin/koha/labels/label-create-csv.pl?batch_id=[% batche.batch_id %]&template_id=[% batche.template_id %]&layout_id=[% batche.layout_id %][% batche.item_numbers %]">label_single_[% batche.label_count %].csv</a> >- </h1> >- </td> >- <td class="borderless"> >- <h1 id="xml"> >- <a href="/cgi-bin/koha/labels/label-create-xml.pl?batch_id=[% batche.batch_id %]&template_id=[% batche.template_id %]&layout_id=[% batche.layout_id %][% batche.item_numbers %]">label_single_[% batche.label_count %].xml</a> >- </h1> >- </td> >- [% ELSE %] >- <td class="borderless"> >- Card batch number [% batche.batch_id %] >- </td> >- <td class="borderless"> >- <h1 id="pdf"> >- <a href="/cgi-bin/koha/labels/label-create-pdf.pl?batch_id=[% batche.batch_id %]&template_id=[% batche.template_id %]&layout_id=[% batche.layout_id %]&start_label=[% batche.start_label %]">label_batch_[% batche.batch_id %].pdf</a> >- </h1> >- </td> >- <td class="borderless"> >- <h1 id="csv"> >- <a href="/cgi-bin/koha/labels/label-create-csv.pl?batch_id=[% batche.batch_id %]&template_id=[% batche.template_id %]&layout_id=[% batche.layout_id %]">label_batch_[% batche.batch_id %].csv</a> >- </h1> >- </td> >- <td class="borderless"> >- <h1 id="xml"> >- <a href="/cgi-bin/koha/labels/label-create-xml.pl?batch_id=[% batche.batch_id %]&template_id=[% batche.template_id %]&layout_id=[% batche.layout_id %]">label_batch_[% batche.batch_id %].xml</a> >- </h1> >- </td> >- [% END %] >- </tr> >- [% END %] >- </table> >- </fieldset> >- <fieldset class="action"> >- <div style="margin: 10px 10px 10px 0px;"> >- <span class="yui-button yui-link-button"><span class="first-child"><input type="button" id="done" onclick="parent.parent.GB_hide();" value="Done"></span></span> >- </div> >- </fieldset> >- </form> >- [% ELSE %] >- <div align="center"> >- <div class="message"> >- [% IF ( label_ids ) %] >- <b>Exporting [% label_count %] cards(s).</b> >- [% ELSIF ( item_numbers ) %] >- <b>Exporting [% item_count %] cards(s).</b> >- [% ELSE %] >- <b>[% multi_batch_count %] batch(es) to export.</b> >- [% END %] >- </div> >- </div> >- <form name="exporting" method="post" action="/cgi-bin/koha/labels/label-print.pl"> >- <input type="hidden" name="op" value="export" /> >- <input type="hidden" name="referer" value="[% referer %]" /> >- [% FOREACH batch_id IN batch_ids %] >- <input type="hidden" name="batch_id" value="[% batch_id.batch_id %]" /> >- [% END %] >- [% FOREACH label_id IN label_ids %] >- <input type="hidden" name="label_id" value="[% label_id.label_id %]" /> >- [% END %] >- [% FOREACH item_number IN item_numbers %] >- <input type="hidden" name="item_number" value="[% item_number.item_number %]" /> >- [% END %] >- <fieldset class="rows"> >- <table class="borderless"> >- <tr> >- <td class="borderless"> >- <label for="template">Select a template to be applied: </label> >- </td> >- <td class="borderless"> >- <select name="template_id"> >- [% FOREACH template IN templates %] >- <option value="[% template.template_id %]">[% template.template_code %]</option> >- [% END %] >- </select> >- </td> >- </tr> >- <tr> >- <td class="borderless"> >- <label for="layout">Select a layout to be applied: </label> >- </td> >- <td class="borderless"> >- <select name="layout_id"> >- [% FOREACH layout IN layouts %] >- <option value="[% layout.layout_id %]">[% layout.layout_name %]</option> >- [% END %] >- </select> >- </td> >- </tr> >- <tr> >- <td class="borderless"> >- <label for="start_label">Enter starting card number: </label> >- </td> >- <td class="borderless"> >- <input type="text" size="5" id="start_label" name="start_label" class="focus" title="Starting card number" value="1"/> >- </td> >- </tr> >- </table> >- </fieldset> >- <fieldset class="action"> >- <div style="margin: 10px 10px 10px 0px;"> >- <span class="yui-button yui-link-button"><span class="first-child"><input type="submit" value="Export" /></span></span> >- <span class="yui-button yui-link-button"><span class="first-child"><input type="button" id="done" onclick="parent.parent.GB_hide();" value="Cancel"></span></span> >- </div> >- </fieldset> >- </form> >- [% END %] >- </div> >- [% INCLUDE 'intranet-bottom.inc' %] >diff --git a/patroncards/card-print.pl b/patroncards/card-print.pl >deleted file mode 100755 >index 6f2970a..0000000 >--- a/patroncards/card-print.pl >+++ /dev/null >@@ -1,131 +0,0 @@ >-#!/usr/bin/perl >-# >-# Copyright 2009 Foundations Bible College. >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it >-# under the terms of the GNU General Public License as published by >-# the Free Software Foundation; either version 3 of the License, or >-# (at your option) any later version. >-# >-# Koha is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >-# GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License >-# along with Koha; if not, see <http://www.gnu.org/licenses>. >- >-use strict; >-use warnings; >- >-use CGI qw ( -utf8 ); >-use Data::Dumper; >- >-use C4::Auth qw(get_template_and_user); >-use C4::Output qw(output_html_with_http_headers); >-use C4::Creators; >-use C4::Labels; >- >-my $cgi = new CGI; >-my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >- { >- template_name => "patroncards/card-print.tt", >- query => $cgi, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => { catalogue => 1 }, >- debug => 1, >- } >-); >- >-my $op = $cgi->param('op') || 'none'; >-my @label_ids = $cgi->param('label_id') if $cgi->param('label_id'); # this will handle individual label printing >-my @batch_ids = $cgi->param('batch_id') if $cgi->param('batch_id'); >-my $layout_id = $cgi->param('layout_id') || undef; >-my $template_id = $cgi->param('template_id') || undef; >-my $start_label = $cgi->param('start_label') || 1; >-my @item_numbers = $cgi->param('item_number') if $cgi->param('item_number'); >-my $output_format = $cgi->param('output_format') || 'pdf'; >-my $referer = $cgi->param('referer') || undef; >- >-my $layouts = undef; >-my $templates = undef; >-my $label_output_formats = undef; >-my @batches = (); >-my $multi_batch_count = scalar(@batch_ids); >-my $label_count = scalar(@label_ids); >-my $item_count = scalar(@item_numbers); >- >-if ($op eq 'export') { >- if (@label_ids) { >- my $label_id_param = '&label_id='; >- $label_id_param .= join ('&label_id=',@label_ids); >- push (@batches, {create_script => ($output_format eq 'pdf' ? 'label-create-pdf.pl' : 'label-create-csv.pl'), >- batch_id => $batch_ids[0], >- template_id => $template_id, >- layout_id => $layout_id, >- start_label => $start_label, >- label_ids => $label_id_param, >- label_count => scalar(@label_ids), >- }); >- $template->param( >- batches => \@batches, >- referer => $referer, >- ); >- } >- elsif (@item_numbers) { >- my $item_number_param = '&item_number='; >- $item_number_param .= join ('&item_number=',@item_numbers); >- push (@batches, {create_script => ($output_format eq 'pdf' ? 'label-create-pdf.pl' : 'label-create-csv.pl'), >- template_id => $template_id, >- layout_id => $layout_id, >- start_label => $start_label, >- item_numbers => $item_number_param, >- label_count => scalar(@item_numbers), >- }); >- $template->param( >- batches => \@batches, >- referer => $referer, >- ); >- } >- elsif (@batch_ids) { >- foreach my $batch_id (@batch_ids) { >- push (@batches, {create_script => ($output_format eq 'pdf' ? 'label-create-pdf.pl' : 'label-create-csv.pl'), >- batch_id => $batch_id, >- template_id => $template_id, >- layout_id => $layout_id, >- start_label => $start_label, >- }); >- } >- $template->param( >- batches => \@batches, >- referer => $referer, >- ); >- } >-} >-elsif ($op eq 'none') { >- # setup select menus for selecting layout and template for this run... >- $referer = $ENV{'HTTP_REFERER'}; >- $referer =~ s/^.*?:\/\/.*?(\/.*)$/$1/m; >- @batch_ids = grep{$_ = {batch_id => $_}} @batch_ids; >- @label_ids = grep{$_ = {label_id => $_}} @label_ids; >- @item_numbers = grep{$_ = {item_number => $_}} @item_numbers; >- $templates = get_all_templates(field_list => 'template_id, template_code'); >- $layouts = get_all_layouts(field_list => 'layout_id, layout_name'); >- $label_output_formats = get_label_output_formats(); >- $template->param( >- batch_ids => \@batch_ids, >- label_ids => \@label_ids, >- item_numbers => \@item_numbers, >- templates => $templates, >- layouts => $layouts, >- label_output_formats => $label_output_formats, >- multi_batch_count => $multi_batch_count, >- label_count => $label_count, >- item_count => $item_count, >- referer => $referer, >- ); >-} >-output_html_with_http_headers $cgi, $cookie, $template->output; >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16077
:
49172
|
49176
| 49202