Bug 16077 - Remove unused script and template card-print
Summary: Remove unused script and template card-print
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/patroncards/card-print.pl
Keywords:
Depends on:
Blocks: 16078
  Show dependency treegraph
 
Reported: 2016-03-15 13:57 UTC by Owen Leonard
Modified: 2016-12-05 21:27 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16077 - Remove unused script and template card-print (16.88 KB, patch)
2016-03-15 14:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16077 - Remove unused script and template card-print (16.98 KB, patch)
2016-03-15 15:26 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16077 - Remove unused script and template card-print (17.27 KB, patch)
2016-03-16 09:08 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-15 13:57:56 UTC
I can find no place where "card-print.pl" is referred to anywhere in Koha.

"card-print.tt" is only referenced by card-print.pl.

I think both can be removed.
Comment 1 Owen Leonard 2016-03-15 14:04:05 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-15 15:26:29 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-16 09:08:39 UTC
Created attachment 49202 [details] [review]
Bug 16077 - Remove unused script and template card-print

I can find no reference to card-print.pl being used in Koha. This patch
deletes it and its associated template.

To test, apply the patch and search for references to "card-print" in
Koha. There should be none.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This script does not work, it fails with 'Undefined subroutine
get_label_output_formats'. This subroutine was in C4::Labels::Lib which
has been removed by 2433a91 (Feb 8 2010): Removing depricated file from the
C4::Labels module.
Comment 4 Jonathan Druart 2016-03-16 09:09:18 UTC
Good catch Owen!
Comment 5 Brendan Gallagher 2016-03-22 00:44:04 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!