Attachment 49344 Details for Bug 15119 – [PASSED QA] Bug 15119: Hide search header text boxes on render

[patch] [PASSED QA] Bug 15119: Hide search header text boxes on render

PASSED-QA-Bug-15119-Hide-search-header-text-boxes-.patch (text/plain), 2.66 KB, created by Katrin Fischer on 2016-03-20 20:32:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-03-20 20:32:03 UTC

Size: 2.66 KB

patch

obsolete

>From 8b0bdd1d83df4996c0670be49cc6ec0d39d581d1 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 6 Jan 2016 13:10:00 +0000
>Subject: [PATCH] [PASSED QA] Bug 15119: Hide search header text boxes on
> render
>
>When the page rendering is slow or the page is heavy, the tabs in the
>header shown be not correctly displayed as tabs.
>
>This patch suggests to hide them, display the first one, and wait for
>the JS code to display them nicely.
>
>To easily reproduced the ergonomic issue, go on the circulation home
>page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or
>'d', you will get a lot of result and the page will be slow to be fully
>displayed.
>
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Works as advertised
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css | 9 +++++++++
> koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js   | 2 ++
> 2 files changed, 11 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>index e6116ce..3294460 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>@@ -2285,6 +2285,15 @@ ul.ui-tabs-nav li {
>      border-radius: 0 0 4px 4px;
> }
> 
>+#header_search > div,
>+#header_search > ul > li {
>+    display: none;
>+}
>+#header_search > div:first-of-type,
>+#header_search > ul > li:first-of-type {
>+    display: block;
>+}
>+
> .authref {
>     font-style: normal;
>     text-indent: 4em;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js
>index 6049fbc..599a3bd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js
>@@ -34,6 +34,8 @@ $.fn.selectTabByID = function (tabID) {
>     if($("#header_search #catalog_search").length > 0){ shortcut.add('Alt+q',function (){ $("#header_search").selectTabByID("#catalog_search"); $("#search-form").focus(); }); } else { shortcut.add('Alt+q',function(){ location.href="/cgi-bin/koha/catalogue/search.pl"; }); }
>     if($("#header_search #renew_search").length > 0){ shortcut.add('Alt+y',function (){ $("#header_search").selectTabByID("#renew_search"); $("#ren_barcode").focus(); }); } else { shortcut.add('Alt+y',function(){ location.href="/cgi-bin/koha/circ/renew.pl"; }); }
> 
>+    $("#header_search > ul > li").show();
>+
>     $(".focus").focus();
>     $(".validated").each(function() {
>         $(this).validate();
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15119: 46325 | 46377 | 48965 | 48988 | 49344