Attachment 49449 Details for Bug 16027 – Bug 16027 - Use Font Awesome icons in the professional cataloging interface

[patch] Bug 16027 - Use Font Awesome icons in the professional cataloging interface

Bug-16027---Use-Font-Awesome-icons-in-the-professi.patch (text/plain), 6.71 KB, created by Mark Tompsett on 2016-03-23 16:05:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2016-03-23 16:05:39 UTC

Size: 6.71 KB

patch

obsolete

>From 29f822a54372deee30082c2e3566c9c951d947c1 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 14 Mar 2016 12:41:58 -0400
>Subject: [PATCH] Bug 16027 - Use Font Awesome icons in the professional
> cataloging interface
>
>The professional cataloging interface uses Glyphicons. They should be
>replaced with Font Awesome icons.
>
>I have replaced the "Import record" icon as per the discussion on Bug
>15966 about which icon better expresses import vs. export.
>
>To test, apply the patch and go to Cataloging -> Advanced editor.
>
>- Confirm that the icons in the toolbar look correct.
>- Click the "Macros" button and confirm that toolbar buttons in the
>  modal look correct.
>- Click the "Advanced" link in the left-hand sidebar and confirm that
>  the buttons in that modal look correct.
>- Click the "Save" button without adding anything to the blank record.
>  Confirm that the "Missing..." error messages are styled with the
>  correct icon.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> .../lib/koha/cateditor/marc-editor.js              |  2 +-
> .../prog/en/modules/cataloguing/editor.tt          | 22 +++++++++++-----------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js b/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js
>index 1fe5e37..3b8622a 100644
>--- a/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js
>+++ b/koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js
>@@ -570,7 +570,7 @@ define( [ 'marc-record', 'koha-backend', 'preferences', 'text-marc', 'widget' ],
> 
>             if ( found ) return;
> 
>-            var node = $( '<div class="structure-error"><i class="icon-remove"></i> ' + error + '</div>' )[0];
>+            var node = $( '<div class="structure-error"><i class="fa fa-remove"></i> ' + error + '</div>' )[0];
>             var widget = this.cm.addLineWidget( line, node, options );
> 
>             widget.node = node;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
>index 2b7152c..90fdf85 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
>@@ -30,19 +30,19 @@
> <div id="editor">
>     <input id="import-records-input" type="file" style="display: none">
>     <div id="toolbar" class="btn-toolbar">
>-        <button class="btn btn-small" id="new-record" title="Open fresh record"><i class="icon-plus"></i> <span>New record</span></button>
>+        <button class="btn btn-small" id="new-record" title="Open fresh record"><i class="fa fa-plus"></i> <span>New record</span></button>
>         <div class="btn-group">
>-            <button class="btn btn-small" id="save-record" title="Save current record (Ctrl-S)"><i class="icon-hdd"></i> <span>Save</span></button>
>+            <button class="btn btn-small" id="save-record" title="Save current record (Ctrl-S)"><i class="fa fa-hdd-o"></i> <span>Save</span></button>
>             <button class="btn btn-small dropdown-toggle" data-toggle="dropdown">
>             <span class="caret"></span>
>             </button>
>             <ul class="dropdown-menu" id="save-dropdown">
>             </ul>
>         </div>
>-        <button class="btn btn-small" id="import-records" title="Import an ISO2709 or MARCXML record"><i class="icon-upload"></i> <span>Import record...</span></button>
>-        <button class="btn btn-small" id="open-macros" title="Run and edit macros"><i class="icon-play"></i> <span>Macros...</span></button>
>+        <button class="btn btn-small" id="import-records" title="Import an ISO2709 or MARCXML record"><i class="fa fa-download"></i> <span>Import record...</span></button>
>+        <button class="btn btn-small" id="open-macros" title="Run and edit macros"><i class="fa fa-play"></i> <span>Macros...</span></button>
>         <div class="btn-group">
>-            <button class="btn btn-small dropdown-toggle" data-toggle="dropdown"><i class="icon-cog"></i> Settings <span class="caret"></span></button>
>+            <button class="btn btn-small dropdown-toggle" data-toggle="dropdown"><i class="fa fa-cog"></i> Settings <span class="caret"></span></button>
>             <ul id="prefs-menu" class="dropdown-menu">
>                 <li><a id="switch-editor" href="#">Switch to basic editor</a></li>
>                 <li><a id="set-field-widgets" href="#"></a></li>
>@@ -60,8 +60,8 @@
>                 <li><a class="set-font" style="font-family: Monaco" href="#">Monaco</a></li>
>             </ul>
>         </div>
>-        <button class="btn btn-small" id="show-alerts" title="Previous alerts"><i class="icon-bell"></i> Alerts <span class="caret"></span></button>
>-        <button class="btn btn-small" id="show-shortcuts" title="Supported keyboard shortcuts"><i class="icon-list-alt"></i> Keyboard shortcuts <span class="caret"></span></button>
>+        <button class="btn btn-small" id="show-alerts" title="Previous alerts"><i class="fa fa-bell"></i> Alerts <span class="caret"></span></button>
>+        <button class="btn btn-small" id="show-shortcuts" title="Supported keyboard shortcuts"><i class="fa fa-keyboard-o"></i> Keyboard shortcuts <span class="caret"></span></button>
>     </div>
>     [%# CodeMirror instance will be inserted here %]
>     <div id="statusbar">
>@@ -114,8 +114,8 @@
>     </div>
>     <div class="span9">
>         <div id="toolbar" class="btn-toolbar">
>-            <button class="btn btn-small" type="submit"><i class="icon-search"></i> <span>Search</span></button>
>-            <button class="btn btn-small" type="reset"><i class="icon-remove"></i> <span>Clear</span></button>
>+            <button class="btn btn-small" type="submit"><i class="fa fa-search"></i> <span>Search</span></button>
>+            <button class="btn btn-small" type="reset"><i class="fa fa-trash"></i> <span>Clear</span></button>
>         </div>
>         <ul id="advanced-search-fields">
>             <li>
>@@ -224,8 +224,8 @@
>     <div class="span3"><ul id="macro-list"></ul></div>
>     <div class="span9" id="macro-editor">
>         <div id="macro-toolbar" class="btn-toolbar">
>-            <button class="btn btn-small" id="run-macro" title="Run and edit macros"><i class="icon-play"></i> Run macro</button>
>-            <button class="btn btn-small" id="delete-macro" title="Delete macro"><i class="icon-remove"></i> Delete macro</button>
>+            <button class="btn btn-small" id="run-macro" title="Run and edit macros"><i class="fa fa-play"></i> Run macro</button>
>+            <button class="btn btn-small" id="delete-macro" title="Delete macro"><i class="fa fa-remove"></i> Delete macro</button>
>             <label for="macro-format">Format: </label> <select id="macro-format"></select>
>             <div id="macro-save-message"></div>
>         </div>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16027: 49126 | 49449 | 49462