Bug 16027 - Use Font Awesome icons in the professional cataloging interface
Summary: Use Font Awesome icons in the professional cataloging interface
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/cataloguing/editor.pl
Keywords:
Depends on:
Blocks: 16080
  Show dependency treegraph
 
Reported: 2016-03-09 15:57 UTC by Owen Leonard
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16027 - Use Font Awesome icons in the professional cataloging interface (6.69 KB, patch)
2016-03-14 16:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16027 - Use Font Awesome icons in the professional cataloging interface (6.71 KB, patch)
2016-03-23 16:05 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 16027 - Use Font Awesome icons in the professional cataloging interface (6.78 KB, patch)
2016-03-23 21:20 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-09 15:57:19 UTC
The professional cataloging interface should use Font Awesome icons instead of Glyphicons.
Comment 1 Owen Leonard 2016-03-14 16:58:15 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-03-23 16:05:39 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-23 21:20:38 UTC
Created attachment 49462 [details] [review]
Bug 16027 - Use Font Awesome icons in the professional cataloging interface

The professional cataloging interface uses Glyphicons. They should be
replaced with Font Awesome icons.

I have replaced the "Import record" icon as per the discussion on Bug
15966 about which icon better expresses import vs. export.

To test, apply the patch and go to Cataloging -> Advanced editor.

- Confirm that the icons in the toolbar look correct.
- Click the "Macros" button and confirm that toolbar buttons in the
  modal look correct.
- Click the "Advanced" link in the left-hand sidebar and confirm that
  the buttons in that modal look correct.
- Click the "Save" button without adding anything to the blank record.
  Confirm that the "Missing..." error messages are styled with the
  correct icon.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-24 17:02:12 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-04-08 07:23:31 UTC
Patch pushed to 3.22.x, will be in 3.22.6