The professional cataloging interface should use Font Awesome icons instead of Glyphicons.
Created attachment 49126 [details] [review] Bug 16027 - Use Font Awesome icons in the professional cataloging interface The professional cataloging interface uses Glyphicons. They should be replaced with Font Awesome icons. I have replaced the "Import record" icon as per the discussion on Bug 15966 about which icon better expresses import vs. export. To test, apply the patch and go to Cataloging -> Advanced editor. - Confirm that the icons in the toolbar look correct. - Click the "Macros" button and confirm that toolbar buttons in the modal look correct. - Click the "Advanced" link in the left-hand sidebar and confirm that the buttons in that modal look correct. - Click the "Save" button without adding anything to the blank record. Confirm that the "Missing..." error messages are styled with the correct icon.
Created attachment 49449 [details] [review] Bug 16027 - Use Font Awesome icons in the professional cataloging interface The professional cataloging interface uses Glyphicons. They should be replaced with Font Awesome icons. I have replaced the "Import record" icon as per the discussion on Bug 15966 about which icon better expresses import vs. export. To test, apply the patch and go to Cataloging -> Advanced editor. - Confirm that the icons in the toolbar look correct. - Click the "Macros" button and confirm that toolbar buttons in the modal look correct. - Click the "Advanced" link in the left-hand sidebar and confirm that the buttons in that modal look correct. - Click the "Save" button without adding anything to the blank record. Confirm that the "Missing..." error messages are styled with the correct icon. NOTE: My Advance area was blank until I toggle device twice in the console of Chrome. Same issue before and after patch, code eyeballs well. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 49462 [details] [review] Bug 16027 - Use Font Awesome icons in the professional cataloging interface The professional cataloging interface uses Glyphicons. They should be replaced with Font Awesome icons. I have replaced the "Import record" icon as per the discussion on Bug 15966 about which icon better expresses import vs. export. To test, apply the patch and go to Cataloging -> Advanced editor. - Confirm that the icons in the toolbar look correct. - Click the "Macros" button and confirm that toolbar buttons in the modal look correct. - Click the "Advanced" link in the left-hand sidebar and confirm that the buttons in that modal look correct. - Click the "Save" button without adding anything to the blank record. Confirm that the "Missing..." error messages are styled with the correct icon. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.6