Attachment 49586 Details for Bug 16004 – Bug 16004: [QA Follow-up] Tiny change for unit test and help file

[patch] Bug 16004: [QA Follow-up] Tiny change for unit test and help file

Bug-16004-QA-Follow-up-Tiny-change-for-unit-test-a.patch (text/plain), 3.22 KB, created by Marcel de Rooy on 2016-03-25 11:11:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2016-03-25 11:11:56 UTC

Size: 3.22 KB

patch

obsolete

>From e896488fa2a1290ee55d5b70319eb45958dda579 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 25 Mar 2016 11:46:58 +0100
>Subject: [PATCH] Bug 16004: [QA Follow-up] Tiny change for unit test and help
> file
>Content-Type: text/plain; charset=utf-8
>
>Unit test: Added a few lines to add the CPL branch the test depends on.
>Help file: Changed a few occurrences for new to new_status
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../modules/help/tools/automatic_item_modification_by_age.tt | 8 ++++----
> t/db_dependent/Items/AutomaticItemModificationByAge.t | 7 +++++++
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt
>index ef4f6d7..fc5ab9d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt
>@@ -3,11 +3,11 @@
> 
> This configuration page allows to configure the rules for the automatic item modifications by age cronjob script.
> 
>-Libraries can manage the 'new' status for items. With this script, it will be possible to:
>+Libraries can manage the 'new_status' field for items. With this script, it will be possible to:
> <ul>
> <li>know easily what are the new items in the catalogue.</li>
> <li>display an icon in the search results for new items.</li>
>- <li>configure circulation and fine rules depending the 'new' status.</li>
>+ <li>configure circulation and fine rules depending the 'new_status' field.</li>
> <li>get a RSS/Atom feeds on these new items.</li>
> </ul>
> 
>@@ -23,11 +23,11 @@
> At least one substitution must be defined, else there is no sense to launch the script.
> If the value is an empty string, the field will be deleted.
> <h3>Examples</h3>
>-You want to remove the items.new value for items created 10 days ago:
>+You want to remove the items.new_status value for items created 10 days ago:
> <ul>
> <li>Duration: 10 days</li>
> <li>No condition</li>
>- <li>Substitution: items.new = '' (no value in the input)</li>
>+ <li>Substitution: items.new_status = '' (no value in the input)</li>
> </ul>
> 
> You want to change the items.ccode=1 to items.ccode=2 for items created 7 days ago.
>diff --git a/t/db_dependent/Items/AutomaticItemModificationByAge.t b/t/db_dependent/Items/AutomaticItemModificationByAge.t
>index 0bad51a..6d7abe2 100644
>--- a/t/db_dependent/Items/AutomaticItemModificationByAge.t
>+++ b/t/db_dependent/Items/AutomaticItemModificationByAge.t
>@@ -11,11 +11,18 @@ use C4::Biblio;
> use C4::Context;
> use C4::Items;
> use Koha::DateUtils;
>+use t::lib::TestBuilder;
> 
> my $dbh = C4::Context->dbh;
> $dbh->{AutoCommit} = 0;
> $dbh->{RaiseError} = 1;
> 
>+# this test assumes a CPL branch
>+my $builder = t::lib::TestBuilder->new;
>+if( !$builder->schema->resultset('Branch')->find('CPL') ) {
>+ $builder->build( { source => 'Branch', value => { branchcode => 'CPL' }});
>+}
>+
> $dbh->do(q|
> DELETE FROM marc_subfield_structure
> WHERE kohafield = 'items.new_status' OR kohafield = 'items.stocknumber'
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 16004: 48771 | 48778 | 49585 | 49586