Bug 16004 - Replace items.new with items.new_status
Summary: Replace items.new with items.new_status
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 11023
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-08 09:53 UTC by Jonathan Druart
Modified: 2016-12-05 21:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16004: Replace items.new with items.new_status (14.67 KB, patch)
2016-03-08 09:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16004: Replace items.new with items.new_status (14.72 KB, patch)
2016-03-08 12:41 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 16004: Replace items.new with items.new_status (14.82 KB, patch)
2016-03-25 11:11 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 16004: [QA Follow-up] Tiny change for unit test and help file (3.22 KB, patch)
2016-03-25 11:11 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-03-08 09:53:08 UTC
The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead.
It will be renamed with new_status to avoid the ambiguity.
Comment 1 Jonathan Druart 2016-03-08 09:56:35 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2016-03-08 12:41:48 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-03-25 11:11:53 UTC
Created attachment 49585 [details] [review]
Bug 16004: Replace items.new with items.new_status

The items.new column is badly named, the Koha::Item->new accessor will
never returns this value, but the constructor will be called instead.
This patch renames it with new_status to avoid the ambiguity.

Test plan:
0/ Do not apply this patch
1/ Define some rules in the "Automatic item modifications by age" tool
with at least one items.new field used
2/ Apply this patch
3/ Execute the update DB entry
4/ Reload the tool page and confirm that the changes have been taken
into account

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2016-03-25 11:11:56 UTC
Created attachment 49586 [details] [review]
Bug 16004: [QA Follow-up] Tiny change for unit test and help file

Unit test: Added a few lines to add the CPL branch the test depends on.
Help file: Changed a few occurrences for new to new_status

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Brendan Gallagher 2016-03-31 17:13:18 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks  (schema upgraded too)
Comment 6 Julian Maurice 2016-04-07 05:58:51 UTC
Not needed in stable versions, status changed to RESOLVED