The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. It will be renamed with new_status to avoid the ambiguity.
Created attachment 48771 [details] [review] Bug 16004: Replace items.new with items.new_status The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. This patch renames it with new_status to avoid the ambiguity. Test plan: 0/ Do not apply this patch 1/ Define some rules in the "Automatic item modifications by age" tool with at least one items.new field used 2/ Apply this patch 3/ Execute the update DB entry 4/ Reload the tool page and confirm that the changes have been taken into account
Created attachment 48778 [details] [review] Bug 16004: Replace items.new with items.new_status The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. This patch renames it with new_status to avoid the ambiguity. Test plan: 0/ Do not apply this patch 1/ Define some rules in the "Automatic item modifications by age" tool with at least one items.new field used 2/ Apply this patch 3/ Execute the update DB entry 4/ Reload the tool page and confirm that the changes have been taken into account Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 49585 [details] [review] Bug 16004: Replace items.new with items.new_status The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. This patch renames it with new_status to avoid the ambiguity. Test plan: 0/ Do not apply this patch 1/ Define some rules in the "Automatic item modifications by age" tool with at least one items.new field used 2/ Apply this patch 3/ Execute the update DB entry 4/ Reload the tool page and confirm that the changes have been taken into account Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 49586 [details] [review] Bug 16004: [QA Follow-up] Tiny change for unit test and help file Unit test: Added a few lines to add the CPL branch the test depends on. Help file: Changed a few occurrences for new to new_status Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to Master - Should be in the May 2016 release. Thanks (schema upgraded too)
Not needed in stable versions, status changed to RESOLVED