Bugzilla – Attachment 4961 Details for
Bug 6373
The mandatory fields validation popup doesn't appear in IE8
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch (passed QA)
0001-Corrects-a-validation-problem-on-addbiblio.pl-on-IE8.patch (text/plain), 1.91 KB, created by
Paul Poulain
on 2011-08-11 09:34:45 UTC
(
hide
)
Description:
proposed patch (passed QA)
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2011-08-11 09:34:45 UTC
Size:
1.91 KB
patch
obsolete
>From 4787b1c8bcf70c57dbd397d010cb46d704cd025b Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9rick=20Capovilla?= <frederick.capovilla@sys-tech.net> >Date: Thu, 19 May 2011 10:46:29 -0400 >Subject: [PATCH] Corrects a validation problem on addbiblio.pl on IE8 > >The mandatory fields popup didn't appear when some mandatory fields >weren't filled on IE8. Replacing the "focus" with its JQuery equivalent >corrected the problem. > >[EDIT by Owen Leonard] Removed commented line > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Follow-up by owen, that he forgot to upload on bugzilla: > >Signed-off patch includes one minor edit: I removed the commented-out line >which the jQuery line replaces. We have git to track changes for us, we don't >have to leave old code in. >Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> >--- > .../prog/en/modules/cataloguing/addbiblio.tt | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 0a73ace..ffe7d3c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -161,7 +161,7 @@ function AreMandatoriesNotOk(){ > if( tabflag[tag+subfield+tagnumber][0] != 1 && (document.getElementById(mandatories[i]) != null && ! document.getElementById(mandatories[i]).value || document.getElementById(mandatories[i]) == null)){ > tabflag[tag+subfield+tagnumber][0] = 0 + tabflag[tag+subfield+tagnumber] ; > document.getElementById(mandatories[i]).setAttribute('class','subfield_not_filled'); >- document.getElementById(mandatories[i]).focus(); >+ $('#' + mandatories[i]).focus(); > tabflag[tag+subfield+tagnumber][1]=label[i]; > tabflag[tag+subfield+tagnumber][2]=tab[i]; > } else { >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6373
:
4190
|
4192
| 4961