6373 – The mandatory fields validation popup doesn't appear in IE8

Bug 6373 - The mandatory fields validation popup doesn't appear in IE8

Summary: The mandatory fields validation popup doesn't appear in IE8

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Browser compatibility (show other bugs)
Version:	Main
Hardware:	All All

Importance:	PATCH-Sent (DO NOT USE) normal
Assignee:	Owen Leonard
QA Contact:	Bugs List

URL:
Keywords:

Depends on:
Blocks:

Reported:	2011-05-19 14:58 UTC by Frédérick Capovilla
Modified:	2013-12-05 20:04 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Corrects a validation problem on addbiblio.pl on IE8 (1.45 KB, patch) 2011-05-19 14:58 UTC, Frédérick Capovilla	Details \| Diff \| Splinter Review
Signed-off patch (1.74 KB, patch) 2011-05-19 16:09 UTC, Owen Leonard	Details \| Diff \| Splinter Review
proposed patch (passed QA) (1.91 KB, patch) 2011-08-11 09:34 UTC, Paul Poulain	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Frédérick Capovilla 2011-05-19 14:58:49 UTC Comment hidden (obsolete)

Created attachment 4190 [details] [review]
Corrects a validation problem on addbiblio.pl on IE8

On /cataloguing/addbiblio.pl :
In some cases, the mandatory field validation popup doesn't appear when trying to add a new bibliographic record on IE8.

It seems this line makes IE8 stop executing the AreMandatoriesNotOk function :
document.getElementById(mandatories[i]).focus();

I replaced this line with its JQuery equivalent and it seems to fix the problem:
$('#' + mandatories[i]).focus();

Patch attached

Comment 1 Owen Leonard 2011-05-19 16:09:48 UTC Comment hidden (obsolete)

Created attachment 4192 [details] [review]
Signed-off patch

Signed-off patch includes one minor edit: I removed the commented-out line which the jQuery line replaces. We have git to track changes for us, we don't have to leave old code in.

This patch fixes the problem, which I was able to reproduce in IE8 on Win7.

Comment 2 Frédérick Capovilla 2011-05-19 16:14:41 UTC

Just a detail :
The commented line doesn't seem to have been removed in the signed-off patch...

Comment 3 Owen Leonard 2011-05-19 16:16:52 UTC

> The commented line doesn't seem to have been removed in the signed-off patch...

Indeed. My git-fu must be failing me today.

Comment 4 Paul Poulain 2011-08-11 09:34:45 UTC

Created attachment 4961 [details] [review]
proposed patch (passed QA)

QA comment

As for previous patch for IE8
* Koha not guaranteed to work on IE
* I don't have any IE at hand
* I've reintroduced the comment owen forgot to upload
* I've checked the patch is harmless under FF
* Frédérick & Owen says it worked for them

Marking passed QA

Comment 5 Chris Cormack 2011-08-12 01:46:44 UTC

Pushed, please test

Comment 6 Jared Camins-Esakov 2012-12-31 00:15:53 UTC

There have been no further reports of problems so I am marking this bug resolved.