Bugzilla – Attachment 50053 Details for
Bug 16182
Make phone number clickable to call
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16182: Make phone number clickable to call
Bug-16182-Make-phone-number-clickable-to-call.patch (text/plain), 6.03 KB, created by
Marc Véron
on 2016-04-08 09:29:00 UTC
(
hide
)
Description:
Bug 16182: Make phone number clickable to call
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2016-04-08 09:29:00 UTC
Size:
6.03 KB
patch
obsolete
>From ea3f641b370b334d14ef67ffada51268f6cb1961 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Thu, 31 Mar 2016 21:24:21 +0000 >Subject: [PATCH] Bug 16182: Make phone number clickable to call >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >EDIT: fixing typo, changing sms number from tel: to sms: > >To test: > >1) Go to a patron detail page >2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device > a) in the top left circ-menu.inc > b) primary/secondary/other/organisation/mobile phone numbers > c) alternate address phone number > d) alternate contact phone number > e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable >3) Check to see if there are any phone numbers I have missed. > >Sponsored-by: Catalyst IT > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > .../intranet-tmpl/prog/en/includes/circ-menu.inc | 7 +++---- > .../prog/en/modules/members/moremember.tt | 18 +++++++++--------- > 2 files changed, 12 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >index f545afa..1d6dc9b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >@@ -20,13 +20,13 @@ > [% END %] > > [% IF ( phone ) %]<li class="patronphone"> >- [% phone %] >+ <a href="tel:[% phone %]">[% phone %]</a> > [% ELSE %] > [% IF ( mobile ) %] >- [% mobile %] >+ <a href="tel:[% mobile %]">[% mobile %]</a> > [% ELSE %] > [% IF ( phonepro ) %] >- [% phonepro %] >+ <a href="tel:[% phonepro %]">[% phonepro %]</a> > [% END %] > [% END %]</li> > [% END %] >@@ -107,4 +107,3 @@ > [% END %] > </ul></div> > [% END %] >- >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 6a4add0..ccb817c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -212,17 +212,17 @@ function validate1(date) { > <div class="rows"> > <ol> > [% IF ( I ) %] >- [% IF ( phonepro ) %]<li><span class="label">Organization phone: </span>[% phonepro %]</li>[% END %] >+ [% IF ( phonepro ) %]<li><span class="label">Organization phone: </span><a href="tel:[% phonepro %]">[% phonepro %]</a></li>[% END %] > [% IF ( emailpro ) %]<li class="email"><span class="label">Organization email: </span>[% emailpro %]</li>[% END %] > [% ELSE %] >- [% IF ( phone ) %]<li><span class="label">Primary phone: </span>[% phone %]</li>[% END %] >- [% IF ( phonepro ) %]<li><span class="label">Secondary phone: </span>[% phonepro %]</li>[% END %] >- [% IF ( mobile ) %]<li><span class="label">Other phone: </span>[% mobile %]</li>[% END %] >+ [% IF ( phone ) %]<li><span class="label">Primary phone: </span><a href="tel:[% phone %]">[% phone %]</a></li>[% END %] >+ [% IF ( phonepro ) %]<li><span class="label">Secondary phone: </span><a href="tel:[% phonepro %]">[% phonepro %]</a></li>[% END %] >+ [% IF ( mobile ) %]<li><span class="label">Other phone: </span><a href="tel:[% mobile %]">[% mobile %]</a></li>[% END %] > [% END %] > > [% IF ( P ) %] >- [% IF ( phone ) %]<li><span class="label">Primary phone: </span>[% phone %]</li>[% END %] >- [% IF ( mobile ) %]<li><span class="label">Other phone: </span>[% mobile %]</li>[% END %] >+ [% IF ( phone ) %]<li><span class="label">Primary phone: </span><a href="tel:[% phone %]">[% phone %]</a></li>[% END %] >+ [% IF ( mobile ) %]<li><span class="label">Other phone: </span><a href="tel:[% mobile %]">[% mobile %]</a></li>[% END %] > [% END %] > [% IF ( fax ) %]<li><span class="label">Fax: </span>[% fax %]</li>[% END %] > [% UNLESS ( I ) %] >@@ -336,7 +336,7 @@ function validate1(date) { > <h3>Patron messaging preferences</h3> > [% INCLUDE 'messaging-preference-form.inc' %] > [% IF ( SMSSendDriver ) %] >- <div class="rows"> <ol><li><span class="label">SMS number:</span>[% SMSnumber %] >+ <div class="rows"> <ol><li><span class="label">SMS number:</span><a href="sms:[% SMSnumber %]">[% SMSnumber %]</a> > </li></ol></div> > [% END %] > </div> >@@ -414,7 +414,7 @@ function validate1(date) { > [% IF ( B_state ) %]<li><span class="label">State: </span>[% B_state %]</li>[% END %] > <li><span class="label">ZIP/Postal code: </span>[% B_zipcode %]</li> > [% IF ( B_country ) %]<li><span class="label">Country: </span>[% B_country %]</li>[% END %] >- [% IF ( B_phone ) %]<li><span class="label">Phone: </span>[% B_phone %]</li>[% END %] >+ [% IF ( B_phone ) %]<li><span class="label">Phone: </span><a href="tel:[% B_phone %]">[% B_phone %]</a></li>[% END %] > [% IF ( B_email ) %]<li class="email"><span class="label">Email: </span><a title="[% B_email %]" href="mailto:[% B_email %]">[% B_email %]</a></li>[% END %] > [% IF ( contactnote ) %]<li><span class="label">Contact note: </span> [% contactnote %]</li>[% END %] > </ol> >@@ -433,7 +433,7 @@ function validate1(date) { > [% IF ( altcontactstate ) %]<li><span class="label">State: </span>[% altcontactstate %]</li>[% END %] > <li><span class="label">ZIP/Postal code: </span>[% altcontactzipcode %]</li> > [% IF ( altcontactcountry ) %]<li><span class="label">Country: </span>[% altcontactcountry %]</li>[% END %] >- [% IF ( altcontactphone ) %]<li><span class="label">Phone: </span>[% altcontactphone %]</li>[% END %] >+ [% IF ( altcontactphone ) %]<li><span class="label">Phone: </span><a href="tel:[% altcontactphone %]">[% altcontactphone %]</a></li>[% END %] > </ol></div> > </div> > <div class="action"><a href="memberentry.pl?op=modify&borrowernumber=[% borrowernumber %]&step=2">Edit</a></div> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16182
:
49747
|
50045
|
50053
|
50569