Bug 16182 - Make phone number clickable to call
Summary: Make phone number clickable to call
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-31 21:35 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16182: Make phone number clickable to call (5.84 KB, patch)
2016-03-31 21:40 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16182: Make phone number clickable to call (5.89 KB, patch)
2016-04-07 22:27 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16182: Make phone number clickable to call (6.03 KB, patch)
2016-04-08 09:29 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16182: Make phone number clickable to call (6.03 KB, patch)
2016-04-22 07:56 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-31 21:35:17 UTC
Email addresses are clickable on member detail pages. It would be good to have phone numbers clickable in the same way.
Comment 1 Aleisha Amohia 2016-03-31 21:40:57 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-04-04 17:34:49 UTC
Should the SMS number link use '<a href="sms: ' instead?

Failing because there is a typo in moremember.tt on line 225:

<a href="te:
Comment 3 Aleisha Amohia 2016-04-07 22:27:18 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-04-08 09:29:00 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-04-08 13:43:28 UTC
Should not we make these links visible/clickable only for mobile devices?
Comment 6 Aleisha Amohia 2016-04-08 20:44:47 UTC
(In reply to Jonathan Druart from comment #5)
> Should not we make these links visible/clickable only for mobile devices?


I can click them from my macbook, it opens up FaceTime I think.
Comment 7 Jonathan Druart 2016-04-11 06:46:35 UTC
I get
"""
The address wasn't understood

Iceweasel doesn't know how to open this address, because one of the following protocols (tel) isn't associated with any program or is not allowed in this context.

You might need to install other software to open this address.
"""
Comment 8 Marcel de Rooy 2016-04-22 07:50:38 UTC
(In reply to Jonathan Druart from comment #5)
> Should not we make these links visible/clickable only for mobile devices?

Some mobile devices may not need the link and discover that it is a phone number anyway. If you install a app/plugin on your desktop, you can make this work too.
Comment 9 Marcel de Rooy 2016-04-22 07:56:21 UTC
Created attachment 50569 [details] [review]
Bug 16182: Make phone number clickable to call

EDIT: fixing typo, changing sms number from tel: to sms:

To test:

1) Go to a patron detail page
2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device
	a) in the top left circ-menu.inc
	b) primary/secondary/other/organisation/mobile phone numbers
	c) alternate address phone number
	d) alternate contact phone number
	e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable
3) Check to see if there are any phone numbers I have missed.

Sponsored-by: Catalyst IT

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Kyle M Hall 2016-04-29 11:02:10 UTC
Pushed to master! Should be in the May 2016 release. Danke Aleisha!