Bugzilla – Attachment 50152 Details for
Bug 14305
Public way to look at the Opac News of different branches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 14305: RSS message correction follow-up
SIGNED-OFF-Bug-14305-RSS-message-correction-follow.patch (text/plain), 1.77 KB, created by
Owen Leonard
on 2016-04-12 15:16:39 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 14305: RSS message correction follow-up
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-04-12 15:16:39 UTC
Size:
1.77 KB
patch
obsolete
>From fd3fd86dcd835cd31d0fba83186a32e0279394aa Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 5 Apr 2016 11:52:22 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 14305: RSS message correction follow-up >Content-Type: text/plain; charset="utf-8" > >If a user is not logged in but requests a specific branch, >the RSS feed message fails to mention the branch. > >TEST PLAN >--------- >1) Apply first patch >2) go to OPAC's opac-main.pl?branch={some branch with specific news} > -- notice bad RSS message >3) Apply this patch >4) Repeat step 2 > -- notice branch is properly shown. >5) koha qa test tools > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >index 4a95df9..2ec85cf 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >@@ -50,8 +50,9 @@ > [% END %] > </div> > <div id="rssnews-container"> >+ <!-- Logged in users have a branch code or it could be explicitly set --> > <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-news-rss.pl?branchcode=[% branchcode %]"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png"></a> >- RSS feed for [% IF ( loggedinusername ) %][% Branches.GetName( branchcode ) %] <i>and</i> [% END %] system-wide library news. >+ RSS feed for [% IF ( branchcode ) %][% Branches.GetName( branchcode ) %] <i>and</i> [% END %] system-wide library news. > </div> > [% END %] > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14305
:
41638
|
41639
|
45650
|
45673
|
49917
|
49918
|
49919
|
49920
|
50152
|
50186
|
50187
|
50188