Bug 14305 - Public way to look at the Opac News of different branches
Summary: Public way to look at the Opac News of different branches
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Persson
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 14764
  Show dependency treegraph
 
Reported: 2015-06-01 09:41 UTC by Viktor Sarge
Modified: 2017-06-14 22:16 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug : View arbitrary branch's news (3.23 KB, patch)
2015-08-18 20:55 UTC, Martin Persson
Details | Diff | Splinter Review
Bug 14305: View arbitrary branch's news, RSS fix (1.99 KB, patch)
2015-08-18 21:06 UTC, Martin Persson
Details | Diff | Splinter Review
Bug 14305: View arbitrary branch's news (3.24 KB, patch)
2015-12-14 14:28 UTC, Martin Persson
Details | Diff | Splinter Review
Bug 14305: View arbitrary branch's news (3.28 KB, patch)
2015-12-14 16:34 UTC, Martin Persson
Details | Diff | Splinter Review
Bug 14305: RSS message correction follow-up (1.61 KB, patch)
2016-04-05 15:56 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 14305: View arbitrary branch's news, RSS fix (2.04 KB, patch)
2016-04-05 15:59 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 14305: View arbitrary branch's news (3.33 KB, patch)
2016-04-05 15:59 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 14305: RSS message correction follow-up (1.66 KB, patch)
2016-04-05 15:59 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 14305: RSS message correction follow-up (1.77 KB, patch)
2016-04-12 15:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 14305: View arbitrary branch's news, RSS fix (2.12 KB, patch)
2016-04-13 08:55 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 14305: View arbitrary branch's news (3.40 KB, patch)
2016-04-13 08:55 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 14305: RSS message correction follow-up (1.79 KB, patch)
2016-04-13 08:55 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Viktor Sarge 2015-06-01 09:41:09 UTC
We now have a way to target news to different branches. But as a patron you can only look at news for "all libraries" + when signed in "all libraries + your specific branch". Since news for specific branches seem like a thing that is obviously public information we need to create a way to display switch branch without registering for a new branch while logged in. 

I see two approaches: 

* Seeing news as a widget and switch branch while staying on the same page. This is easily solved with a drop down or something similar. 

* Add real navigation for switching branch. Since we now have unique identifiers for the body-tag in order to be able to brand each branch with a different CSS this might look like the natural order. 


(I do feel that the widget approach still have it's merits. I have seen some good consortia solutions where the starting page is the same for all and you load it with ajax components that can expose branch specific information like opening hours, searches etc. Any help in sorting out how to proceed is welcome..  I recall that there is a bug for a public calendar, and if you also take into account calendar, creating events that show up in both calendar and a separate news-flow, expanding CMS-functionality this might require some thinking)
Comment 1 Martin Persson 2015-08-18 20:55:01 UTC Comment hidden (obsolete)
Comment 2 Martin Persson 2015-08-18 21:06:57 UTC Comment hidden (obsolete)
Comment 3 Martin Persson 2015-12-14 13:44:07 UTC
*** Bug 14764 has been marked as a duplicate of this bug. ***
Comment 4 Martin Persson 2015-12-14 14:28:59 UTC Comment hidden (obsolete)
Comment 5 Martin Persson 2015-12-14 14:33:37 UTC
This ticket overlapped a bit in functionality and actual code with 14764. I am cleaning up both now and marking them properly. This patch only reads the branch from the URL; the user has to create the URLs themselves. This separation is a bit stupid, but the tickets were created before I was familiar with what was practical.
Comment 6 Martin Persson 2015-12-14 16:34:02 UTC Comment hidden (obsolete)
Comment 7 Mark Tompsett 2016-04-05 13:45:50 UTC
Comment on attachment 41639 [details] [review]
Bug 14305: View arbitrary branch's news, RSS fix

Review of attachment 41639 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
@@ -53,2 @@
>                  <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-news-rss.pl?branchcode=[% branchcode %]"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png"></a>
>                  RSS feed for [% IF ( loggedinusername ) %][% Branches.GetName( branchcode ) %] <i>and</i> [% END %] system-wide library news.

If a user is not logged in and passes branchcode=BranchA in the URL, line 54 isn't going to display correctly.
Add '?branch={some branchcode that has specific branch news}' to your opac-main url. Notice the RSS message is wrong.
Comment 8 Mark Tompsett 2016-04-05 15:56:03 UTC Comment hidden (obsolete)
Comment 9 Mark Tompsett 2016-04-05 15:59:05 UTC Comment hidden (obsolete)
Comment 10 Mark Tompsett 2016-04-05 15:59:11 UTC Comment hidden (obsolete)
Comment 11 Mark Tompsett 2016-04-05 15:59:19 UTC Comment hidden (obsolete)
Comment 12 Mark Tompsett 2016-04-05 16:00:06 UTC
Left as Needs Signoff, because I can't sign off my own patch. Please test and sign off.
Comment 13 Mark Tompsett 2016-04-05 16:00:49 UTC
(In reply to M. Tompsett from comment #11)
> TEST PLAN
> ---------
> 1) Apply first patch
 -- actually the first two.

> 2) go to OPAC's opac-main.pl?branch={some branch with specific news}
>    -- notice bad RSS message
> 3) Apply this patch
> 4) Repeat step 2
>    -- notice branch is properly shown.
> 5) koha qa test tools
> 
> Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 14 Owen Leonard 2016-04-12 15:16:39 UTC Comment hidden (obsolete)
Comment 15 Jonathan Druart 2016-04-13 08:55:20 UTC
Created attachment 50186 [details] [review]
Bug 14305: View arbitrary branch's news, RSS fix

This fix changes the RSS link to reflect the URL paramter override.

This is less elegant than the existing solution which uses the
Branches TT module, perhaps there is a better way?

Sponsored-By: Halland County Library

Test plan:
* Follow instructions in the original patch but also check the
  URLs and contents of the RSS link at the bottom the OPAC page.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 16 Jonathan Druart 2016-04-13 08:55:24 UTC
Created attachment 50187 [details] [review]
Bug 14305: View arbitrary branch's news

This patch adds an input named 'branch' to opac-main.pl that
allows overriding the home library to view news from any branch.

This is part of the 'Use Koha as a CMS' development.

To reviewers: Does this create any security implications?
              The column is text; it is possbile to push SQL
              statemens into the DB via the opac-membership.pl
              page, but all the code there seems to use DBIx::Class
              and prepared statements. When attemped, accepting the
              changes were rejected because of the foreign key
              constraint placed on the main borrowers table.

It is recommended to use this patch in conjunction with 11584
which adds a WYSIWYG editor to System Preferences.

Test plan:
* Make sure your Koha installation has multiple branches:
  * Log in to the Staff interface and select 'Koha administration'
  * Select 'Libraries and groups', the first item in the list
  * Add an extra branch named 'BRANCH1':
    * Press the 'New library' button
    * Set 'Library code' to 'BRANCH1'
    * Enter an arbitrary name
    * Press 'Submit'

* Add at least two news items with different branches:
  * Log in to the Staff interface and select 'Tools'
  * Under 'Additional tools' select 'News'
  * On the 'Koha news' page, create a news item for all libraries:
    * Press the 'New entry' button
    * Set 'Library' to 'All libraries' and enter a title.
    * Press 'Submit'
  * On the 'Koha news' page, create a news item for one library:
    * Press the 'New entry' button
    * Set 'Library' to 'BRANCH1' and enter a title
    * Press 'Submit'

* Add links to OPAC to select branch:
  * Select 'System preferences' and then the 'OPAC' tab
  * Scroll down to the 'OpacNav' preference and click 'Click to Edit'
  * Create two hyperlinks with a parameter named 'branch':
    * '<a href="?branch=BRANCH1">BRANCH1</a>'
    * '<a href="?branch=">none</a>'
  * Click 'Save all OPAC preferences'

* Test OPAC:
  * By default, global news and news for home branch should show.
  * When clicking the 'BRANCH1' link, you should see global news
    plus news for the BRANCH1 branch.
  * When the parameter 'branch' is set but has no value,
    news from the home branch should be shown.

Issues: Tricky to create a link to the same page
        which removes existing paramters.

The user normally has a home branch set.
We can override it with the parameter.
If undefined, the home branch should be shown.

Sponsored-by: Halland County Library

http://bugs.koha-community.org/show_bug.cgi?id=14305

Changed 2015-12-14: Whitespace fix

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 17 Jonathan Druart 2016-04-13 08:55:28 UTC
Created attachment 50188 [details] [review]
Bug 14305: RSS message correction follow-up

If a user is not logged in but requests a specific branch,
the RSS feed message fails to mention the branch.

TEST PLAN
---------
1) Apply first patch
2) go to OPAC's opac-main.pl?branch={some branch with specific news}
   -- notice bad RSS message
3) Apply this patch
4) Repeat step 2
   -- notice branch is properly shown.
5) koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 18 Kyle M Hall 2016-04-29 12:45:27 UTC
Pushed to master for the May 2016 release! Obrigado Martin!