Bugzilla – Attachment 51651 Details for
Bug 16548
All libraries selected on Tools -> Export Data screen
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16548 - All libraries selected on Tools -> Export Data screen
Bug-16548---All-libraries-selected-on-Tools---Expo.patch (text/plain), 6.27 KB, created by
Nick Clemens (kidclamp)
on 2016-05-20 13:20:53 UTC
(
hide
)
Description:
Bug 16548 - All libraries selected on Tools -> Export Data screen
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2016-05-20 13:20:53 UTC
Size:
6.27 KB
patch
obsolete
>From 5f577ad4aeac8fe1e5c5722f7bea64a86b26e8aa Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 18 May 2016 19:45:27 -0400 >Subject: [PATCH] Bug 16548 - All libraries selected on Tools -> Export Data > screen > >This patch adds "select all" and "select none" links to the display of >libraries in the export bibliographic records form. > >Also modified: call number range and accession date fields have been >grouped in their own fieldsets in the hopes that this is more readable. >Page title and breadcrumbs have been corrected to read "Export data" >instead of "MARC export," matching menu items. > >To test, apply the patch and go to Tools -> Export data. > >- Test the select all/select none links and confirm that they work as > expected. >- Confirm that the structural changes to the form look okay. > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > .../prog/en/includes/branch-selector.inc | 5 +- > .../intranet-tmpl/prog/en/modules/tools/export.tt | 69 +++++++++++++++------- > 2 files changed, 50 insertions(+), 24 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc >index f3aa11a..2adb0d7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc >@@ -6,13 +6,14 @@ > END; > END %] > <div class="branchselector"> >+ <p><a href="#" id="checkall"> <i class="fa fa-check"></i> Select all</a> | <a href="#" id="checknone"> <i class="fa fa-remove"></i> Select none</a></p> > <div class="branchgridrow"> > [% FOREACH branch IN branches %] > <div class="branchgriditem"> > [% IF branch.selected || (selectall == 1) %] >- <input id="branch_[% branch.value %]" type="checkbox" name="branch" value="[% branch.value %]" checked="checked" /> >+ <input id="branch_[% branch.value %]" class="branch_select" type="checkbox" name="branch" value="[% branch.value %]" checked="checked" /> > [% ELSE %] >- <input id="branch_[% branch.value %]" type="checkbox" name="branch" value="[% branch.value %]" /> >+ <input id="branch_[% branch.value %]" class="branch_select" type="checkbox" name="branch" value="[% branch.value %]" /> > [% END %] > > <label for="branch_[% branch.value %]">[% branch.branchname %]</label> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt >index 5362fa9..cf41e5f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt >@@ -1,5 +1,5 @@ > [% INCLUDE 'doc-head-open.inc' %] >-<title>Koha › Tools › MARC export</title> >+<title>Koha › Tools › Export data</title> > [% INCLUDE 'doc-head-close.inc' %] > [% INCLUDE 'calendar.inc' %] > <script type="text/javascript"> >@@ -17,15 +17,28 @@ $(document).ready(function() { > $("#bibs li.csv_profiles").hide(); > } > }); >+ $("#checkall").on("click",function(e){ >+ e.preventDefault(); >+ $(".branch_select").prop("checked",1); >+ }); >+ $("#checknone").on("click",function(e){ >+ e.preventDefault(); >+ $(".branch_select").prop("checked",0); >+ }); > }); > //]]> > </script> >+<style type="text/css"> >+ fieldset.rows fieldset.rows { >+ width: 90%; >+ } >+</style> > </head> > <body id="tools_export" class="tools"> > [% INCLUDE 'header.inc' %] > [% INCLUDE 'cat-search.inc' %] > >-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> › MARC export</div> >+<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> › Export data</div> > > <div id="doc3" class="yui-t2"> > >@@ -52,7 +65,8 @@ $(document).ready(function() { > <form method="post" enctype="multipart/form-data" action="/cgi-bin/koha/tools/export.pl"> > <fieldset class="rows"> > <legend> Select records to export </legend> >- <ol><li> >+ <ol> >+ <li> > <label for="start">From biblio number: </label> > <input id="start" type="text" name="StartingBiblionumber" size="5" /> > </li> >@@ -80,25 +94,36 @@ $(document).ready(function() { > [% INCLUDE 'branch-selector.inc' > branches = branchloop %] > </li> >- <li> >- <label for="startcn">From item call number: </label> >- <input id="startcn" type="text" name="start_callnumber" size="5" /> >- </li> >- <li> >- <label for="endcn">To item call number: </label> >- <input id="endcn" type="text" name="end_callnumber" size="5" /> >- </li> >- <li>Accession date (inclusive): >- <ul><li> >- <label for="from">Start date:</label> >- <input type="text" size="10" id="from" name="start_accession" value="[% from %]" class="datepickerfrom" /> >-</li> >-<li><label for="to"> >- End date: >-</label> >-<input size="10" id="to" name="end_accession" value="[% end_accession %]" type="text" class="datepickerto" /> >-</li> >-</ul></li></ol> >+ </ol> >+ >+ <fieldset class="rows"> >+ <legend>Call number range</legend> >+ <ol> >+ <li> >+ <label for="startcn">From item call number: </label> >+ <input id="startcn" type="text" name="start_callnumber" size="15" /> >+ </li> >+ <li> >+ <label for="endcn">To item call number: </label> >+ <input id="endcn" type="text" name="end_callnumber" size="15" /> >+ </li> >+ </ol> >+ </fieldset> >+ >+ <fieldset class="rows"> >+ <legend>Accession date (inclusive)</legend> >+ <ol> >+ <li> >+ <label for="from">Start date:</label> >+ <input type="text" size="10" id="from" name="start_accession" value="[% from %]" class="datepickerfrom" /> >+ </li> >+ <li> >+ <label for="to">End date:</label> >+ <input size="10" id="to" name="end_accession" value="[% end_accession %]" type="text" class="datepickerto" /> >+ </li> >+ </ol> >+ </fieldset> >+ > </fieldset> > <fieldset class="rows"> > <legend> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16548
:
51606
|
51651
|
51829
|
51830