Attachment 51721 Details for Bug 16499 – Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl

[patch] Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl

Bug-16499-Remove-Use-of-uninitialized-value-warnin.patch (text/plain), 1.87 KB, created by Kyle M Hall (khall) on 2016-05-23 17:35:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2016-05-23 17:35:12 UTC

Size: 1.87 KB

patch

obsolete

>From fddf8b4648948316967c10cced06459b7f04556f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 11 May 2016 15:05:59 +0100
>Subject: [PATCH] Bug 16499: Remove "Use of uninitialized value" warnings in
> circulation.pl
>
>If you search for a patron in the circulation module, you get:
>
>Use of uninitialized value $barcode in string eq at
>/home/koha/src/circ/circulation.pl line 84.
>Use of uninitialized value $restoreduedatespec in string eq at
>/home/koha/src/circ/circulation.pl line 170.
>
>Test plan:
>- Search for a patron and confirm the warnings are not displayed anymore
>- Make sure this patch does not introduce regression on bug 14015
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> circ/circulation.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/circ/circulation.pl b/circ/circulation.pl
>index 66b3dcf..136b7bf 100755
>--- a/circ/circulation.pl
>+++ b/circ/circulation.pl
>@@ -81,7 +81,7 @@ if (!C4::Context->userenv){
> my $barcodes = [];
> my $barcode =  $query->param('barcode');
> # Barcode given by user could be '0'
>-if ( $barcode || $barcode eq '0' ) {
>+if ( $barcode or defined $barcode and $barcode eq '0' ) {
>     $barcodes = [ $barcode ];
> } else {
>     my $filefh = $query->upload('uploadfile');
>@@ -167,7 +167,7 @@ my $duedatespec    = $query->param('duedatespec')   || $session->param('stickydu
> $duedatespec = eval { output_pref( { dt => dt_from_string( $duedatespec ), dateformat => 'iso' }); }
>     if ( $duedatespec );
> my $restoreduedatespec  = $query->param('restoreduedatespec') || $session->param('stickyduedate') || $duedatespec;
>-if ($restoreduedatespec eq "highholds_empty") {
>+if ($restoreduedatespec and $restoreduedatespec eq "highholds_empty") {
>     undef $restoreduedatespec;
> }
> my $issueconfirmed = $query->param('issueconfirmed');
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16499: 51436 | 51440 | 51635 | 51721 | 51722