Bugzilla – Attachment 52699 Details for
Bug 16762
Record matching rules: Remove match check link removes too much
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 16762: Record matching rules: Remove match check link removes too much
SIGNED-OFFBug-16762-Record-matching-rules-Remove-m.patch (text/plain), 2.42 KB, created by
Héctor Eduardo Castro Avalos
on 2016-06-22 17:52:37 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 16762: Record matching rules: Remove match check link removes too much
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-06-22 17:52:37 UTC
Size:
2.42 KB
patch
obsolete
>From 0b17db1a2cde9d2e217e4ea0806e92ac7affd88d Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 17 Jun 2016 11:33:41 -0400 >Subject: [PATCH] [SIGNED-OFF]Bug 16762: Record matching rules: Remove match > check link removes too much > >My patch for Bug 5006 introduced a lot of markup changes to the record >matching rules template. I missed a change in one are though, which >caused a bug with the way the 'Remove match check' link works. > >To reproduce: > >- Go to Administration -> Record matching rules. >- Edit a matching rule which includes at least one match check. >- Click a 'Remove match check' link. The entire "Required match checks" > block is removed. > >To test, apply the patch and repeat the steps above. Clicking any >'Remove match check' link should remove only the corresponding rule. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as advertised >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt >index e8aecf1..acb33a7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt >@@ -364,7 +364,8 @@ function CheckRuleForm(f) { > [% ELSE %]<p id="addMatchCheck" style="display:none;"><a href="#" class="button" onclick="InsertMatchcheck('mc_1', 'mc_template'); return false;">Add match check</a></p>[% END %] > [% IF ( edit_matching_rule ) %] > [% FOREACH matchcheck IN matchchecks %] >- <fieldset class="rows" id="mc_[% matchcheck.mc_num %]"> >+ <div id="mc_[% matchcheck.mc_num %]" class="matchgroup"> >+ <fieldset class="rows"> > <legend>Match check [% matchcheck.mc_num %]<a href="#" class="button" onclick="InsertMatchcheck('mc_[% matchcheck.mc_num %]', 'mc_template'); return false;">Add match check</a> | <a href="#" class="button" onclick="DeleteMatchcheck(this); return false;">Remove this match check</a></legend> > <input type="hidden" id="mc_[% matchcheck.mc_num %]_id" name="mc_[% matchcheck.mc_num %]_id" value="1" /> > [% FOREACH src_component IN matchcheck.src_components %] >@@ -456,6 +457,8 @@ function CheckRuleForm(f) { > </fieldset> > [% END %] > </fieldset> >+ <br style="clear:both;" /> >+ </div> > [% END %] > [% ELSE %] > <div id="mc_1" class="matchgroup"> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16762
:
52498
|
52699
|
52700
|
52815