Bugzilla – Attachment 54369 Details for
Bug 15407
Move the patron categories related code to Koha::Patron::Categories - part 2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15407: [QA Follow-up] Confusing cathash removed
Bug-15407-QA-Follow-up-Confusing-cathash-removed.patch (text/plain), 1.77 KB, created by
Marcel de Rooy
on 2016-08-12 11:46:17 UTC
(
hide
)
Description:
Bug 15407: [QA Follow-up] Confusing cathash removed
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-08-12 11:46:17 UTC
Size:
1.77 KB
patch
obsolete
>From 9d7eff94287b42d61f7c1dd60dcd20cdc4e350ad Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 12 Aug 2016 13:26:46 +0200 >Subject: [PATCH] Bug 15407: [QA Follow-up] Confusing cathash removed >Content-Type: text/plain; charset=utf-8 > >One of the patches removed %cathash. Some kind of silly remainder >was left in a string. Just used as a text field to explain the >filters used on borrowers_stats.pl. The filter name cathash is not >really easy and also was confusing in relation to the variable. > >So just a string patch, replacing it with Patron category. > >NOTE: The output of borrowers_stats.pl with the filters listed, is >not one of the most beautiful Koha screens. >Furthermore, translatibility of these filters is still an issue to >be handled on another report. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > reports/borrowers_stats.pl | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/reports/borrowers_stats.pl b/reports/borrowers_stats.pl >index 342dad4..a7e656f 100755 >--- a/reports/borrowers_stats.pl >+++ b/reports/borrowers_stats.pl >@@ -260,7 +260,12 @@ sub calculate { > $linefield = $line; > } > my $patron_categories = Koha::Patron::Categories->search({}, {order_by => ['categorycode']}); >- push @loopfilter, {debug=>1, crit=>"\%cathash", filter=>join(", ", map { $_->categorycode . ' (' . ( $_->description || 'NO_DESCRIPTION' ) . ')'} $patron_categories->as_list )}; >+ push @loopfilter, >+ { >+ debug => 1, >+ crit => "Patron category", >+ filter => join( ", ", map { $_->categorycode . ' (' . ( $_->description || 'NO_DESCRIPTION' ) . ')' } $patron_categories->as_list ), >+ }; > > my $strsth; > my @strparams; # bind parameters for the query >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15407
:
45906
|
45907
|
45908
|
45909
|
45910
|
45913
|
45914
|
47098
|
47099
|
47100
|
47101
|
47102
|
47646
|
47647
|
47648
|
47649
|
47650
|
47754
|
47755
|
47756
|
47757
|
47758
|
50170
|
50171
|
50172
|
50173
|
50174
|
52013
|
52014
|
52015
|
52032
|
52033
|
52034
|
52035
|
52036
|
53419
|
53420
|
53421
|
53422
|
53423
|
53892
|
54342
|
54343
|
54344
|
54345
|
54346
|
54352
|
54353
|
54355
|
54361
|
54362
|
54363
|
54364
|
54365
|
54366
|
54367
|
54368
| 54369 |
54371
|
55517