Attachment 55109 Details for Bug 16449 – Bug 16449: Remove "no method selected" warning from unimarc_field_4XX

[patch] Bug 16449: Remove "no method selected" warning from unimarc_field_4XX

Bug-16449-Remove-no-method-selected-warning-from-u.patch (text/plain), 1.89 KB, created by Marcel de Rooy on 2016-09-02 09:41:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2016-09-02 09:41:22 UTC

Size: 1.89 KB

patch

obsolete

>From 7d0345e9729bf6ab0f562f65ee9ffd25925181df Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 5 May 2016 15:25:50 +0100
>Subject: [PATCH] Bug 16449: Remove "no method selected" warning from
> unimarc_field_4XX
>Content-Type: text/plain; charset=utf-8
>
>Because of bug 14828, the unimarc_field_4XX now raises a warning:
>"No method selected!"
>
>There are no need to select an item type on this page, the default (all)
>is always selected.
>
>Test plan:
>Link the unimarc_field_4XX value builder with on of the subfield
>Edit a record, click on the value builder icon
>Note the warning without the patch and that it's gone with the patch
>applied
>
>NOTE: Code fix that I derived was identical. Ran
> prove t/db_dependent/FrameworkPlugin.t
>to confirm it works.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt |    4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt
>index 458c199..b784c3a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt
>@@ -129,12 +129,8 @@
> 				<select name="itype" id="itypeloop">
>                 <option value="">All item types</option>
> 				[% FOREACH itypeloo IN itypeloop %]
>-				[% IF ( itypeloo.selected ) %]
>-                <option value="[% itypeloo.itemtype %]" selected="selected">[% itypeloo.description |html %]</option>
>-				[% ELSE %]
>                 <option value="[% itypeloo.itemtype %]">[% itypeloo.description |html %]</option>
> 				[% END %]
>-				[% END %]
> 				</select>
> 			</p>
> 			<p>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 16449: 51238 | 53491 | 55109